Add AlwaysTrue and AlwaysFalse to Predicate
#319
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 4, 2024
Contributor
Author
|
@liurenjie1024 and @marvinlanhenke - small PR split out from #241 ready for review! |
Contributor
Author
|
merged this into #320 as it is a bit pointless on its own |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been broken out of #241 as it was getting too large.
This should be pretty uncontroversial -
AlwaysTrueandAlwaysFalseare already present inBoundPredicate. When projectingBoundPredicateback into aPredicatewhilst evaluating manifests in table scans, we need these so that their bound equivalents can be mapped back toPredicatevalues.