From bedd810e66f4a6987333bce1351fc072b8319766 Mon Sep 17 00:00:00 2001
From: liurenjie1024 <liurenjie2008@gmail.com>
Date: Wed, 28 May 2025 18:14:58 +0800
Subject: [PATCH] Revert "feat: Introduce snapshot summary properties (#1336)"

This reverts commit 8bb9a882c7e5f6cfd2a9762136e874421cd7fb59.
---
 crates/iceberg/src/catalog/mod.rs             | 29 --------
 crates/iceberg/src/spec/snapshot.rs           |  5 --
 .../src/spec/table_metadata_builder.rs        | 74 -------------------
 crates/iceberg/src/transaction/mod.rs         | 12 ---
 4 files changed, 120 deletions(-)

diff --git a/crates/iceberg/src/catalog/mod.rs b/crates/iceberg/src/catalog/mod.rs
index 545a2bbbc7..3457f83611 100644
--- a/crates/iceberg/src/catalog/mod.rs
+++ b/crates/iceberg/src/catalog/mod.rs
@@ -495,12 +495,6 @@ pub enum TableUpdate {
         /// Schema IDs to remove.
         schema_ids: Vec<i32>,
     },
-    /// Add snapshot summary properties.
-    #[serde(rename_all = "kebab-case")]
-    AddSnapshotSummaryProperties {
-        /// Additional properties to add.
-        properties: HashMap<String, String>,
-    },
 }
 
 impl TableUpdate {
@@ -545,9 +539,6 @@ impl TableUpdate {
                 Ok(builder.remove_partition_statistics(snapshot_id))
             }
             TableUpdate::RemoveSchemas { schema_ids } => builder.remove_schemas(&schema_ids),
-            TableUpdate::AddSnapshotSummaryProperties { properties } => {
-                builder.add_snapshot_summary_properties(properties)
-            }
         }
     }
 }
@@ -2107,24 +2098,4 @@ mod tests {
             },
         );
     }
-
-    #[test]
-    fn test_add_snapshot_summary_properties() {
-        let mut expected_properties = HashMap::new();
-        expected_properties.insert("prop-key".to_string(), "prop-value".to_string());
-
-        test_serde_json(
-            r#"
-                {
-                    "action": "add-snapshot-summary-properties",
-                    "properties": {
-                            "prop-key": "prop-value"
-                    }
-                }        
-            "#,
-            TableUpdate::AddSnapshotSummaryProperties {
-                properties: expected_properties,
-            },
-        );
-    }
 }
diff --git a/crates/iceberg/src/spec/snapshot.rs b/crates/iceberg/src/spec/snapshot.rs
index 12e862f1ea..a2716ad97e 100644
--- a/crates/iceberg/src/spec/snapshot.rs
+++ b/crates/iceberg/src/spec/snapshot.rs
@@ -214,11 +214,6 @@ impl Snapshot {
             snapshot_id: self.snapshot_id,
         }
     }
-
-    /// Add the given properties map to snapshot summary.
-    pub(crate) fn add_summary_properties(&mut self, props: HashMap<String, String>) {
-        self.summary.additional_properties.extend(props);
-    }
 }
 
 pub(super) mod _serde {
diff --git a/crates/iceberg/src/spec/table_metadata_builder.rs b/crates/iceberg/src/spec/table_metadata_builder.rs
index 2408e57d69..1f3f89533b 100644
--- a/crates/iceberg/src/spec/table_metadata_builder.rs
+++ b/crates/iceberg/src/spec/table_metadata_builder.rs
@@ -1244,33 +1244,6 @@ impl TableMetadataBuilder {
 
         Ok(self)
     }
-
-    /// Add summary properties to the latest snapshot for the table metadata.
-    pub fn add_snapshot_summary_properties(
-        mut self,
-        properties: HashMap<String, String>,
-    ) -> Result<Self> {
-        if properties.is_empty() {
-            return Ok(self);
-        }
-
-        let snapshot_id = self.metadata.current_snapshot_id.unwrap();
-        let mut cur_snapshot = self
-            .metadata
-            .snapshots
-            .remove(&snapshot_id)
-            .unwrap()
-            .as_ref()
-            .clone();
-        cur_snapshot.add_summary_properties(properties.clone());
-        self.metadata
-            .snapshots
-            .insert(snapshot_id, Arc::new(cur_snapshot));
-        self.changes
-            .push(TableUpdate::AddSnapshotSummaryProperties { properties });
-
-        Ok(self)
-    }
 }
 
 impl From<TableMetadataBuildResult> for TableMetadata {
@@ -2523,51 +2496,4 @@ mod tests {
             };
         assert_eq!(remove_schema_ids, &[0]);
     }
-
-    #[test]
-    fn test_add_snapshot_summary_properties() {
-        let file = File::open(format!(
-            "{}/testdata/table_metadata/{}",
-            env!("CARGO_MANIFEST_DIR"),
-            "TableMetadataV2Valid.json"
-        ))
-        .unwrap();
-        let reader = BufReader::new(file);
-        let resp = serde_json::from_reader::<_, TableMetadata>(reader).unwrap();
-
-        let table = Table::builder()
-            .metadata(resp)
-            .metadata_location("s3://bucket/test/location/metadata/v1.json".to_string())
-            .identifier(TableIdent::from_strs(["ns1", "test1"]).unwrap())
-            .file_io(FileIOBuilder::new("memory").build().unwrap())
-            .build()
-            .unwrap();
-        assert!(
-            table
-                .metadata()
-                .current_snapshot()
-                .unwrap()
-                .summary()
-                .additional_properties
-                .is_empty()
-        );
-
-        let mut new_properties = HashMap::new();
-        new_properties.insert("prop-key".to_string(), "prop-value".to_string());
-
-        let mut meta_data_builder = table.metadata().clone().into_builder(None);
-        meta_data_builder = meta_data_builder
-            .add_snapshot_summary_properties(new_properties.clone())
-            .unwrap();
-        let build_result = meta_data_builder.build().unwrap();
-        assert_eq!(
-            build_result
-                .metadata
-                .current_snapshot()
-                .unwrap()
-                .summary()
-                .additional_properties,
-            new_properties
-        );
-    }
 }
diff --git a/crates/iceberg/src/transaction/mod.rs b/crates/iceberg/src/transaction/mod.rs
index 7f949c3aa8..ba79d60bbd 100644
--- a/crates/iceberg/src/transaction/mod.rs
+++ b/crates/iceberg/src/transaction/mod.rs
@@ -128,18 +128,6 @@ impl<'a> Transaction<'a> {
         Ok(self)
     }
 
-    /// Add snapshot summary properties.
-    pub fn add_snapshot_summary_properties(
-        mut self,
-        props: HashMap<String, String>,
-    ) -> Result<Self> {
-        self.apply(
-            vec![TableUpdate::AddSnapshotSummaryProperties { properties: props }],
-            vec![],
-        )?;
-        Ok(self)
-    }
-
     fn generate_unique_snapshot_id(&self) -> i64 {
         let generate_random_id = || -> i64 {
             let (lhs, rhs) = Uuid::new_v4().as_u64_pair();