feat: Add hms catalog layout #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <[email protected]>
Member
Author
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
2 tasks
Fokko
approved these changes
Dec 7, 2023
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
This look good! I'm thinking to add a HMS to the CI for the Python part, might also be interesting for Rust to run integration tests against.
shaeqahmed
pushed a commit
to matanolabs/iceberg-rust
that referenced
this pull request
Dec 9, 2024
* feat: Add hms catalog layout Signed-off-by: Xuanwo <[email protected]> * Fix Signed-off-by: Xuanwo <[email protected]> * Sort deps Signed-off-by: Xuanwo <[email protected]> --------- Signed-off-by: Xuanwo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a basic layout for hms support.
This PR solely implements
list_namespaces, allowing us to concentrate on crucial matters such as general API style and creating room for future implementation.TODO
There is a plan for hive_metastore to migrate to
volofor better hive metastore client that don't need thrift, async support and so on. But it requires rust nightly (rust 1.75).We should not be blocked by Xuanwo/hive_metastore_rs#2. Let's move on and migrate after rust 1.75 released.