feat: Add NameMapping
#1072
Closed
feat: Add NameMapping
#1072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-n/iceberg-rust into implement-name-mapping
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @jonathanc-n for this pr, generally I think this is quite useful to complete features of NameMapping. Here are my suggestions:
- Split the pr into several smaller ones.
- Add
MappedFieldslike java does. - Add visitor for index by name and index by field id with enough tests
- Add visitor for update mappings with tests.
| } | ||
|
|
||
| /// Returns an index mapping names to `MappedField`` by visiting the schema. | ||
| pub fn index_by_name(schema: &Schema) -> HashMap<String, MappedField> { |
Contributor
There was a problem hiding this comment.
I don't think we should expose this method to user, the index should be constructed lazily.
| #[derive(Debug, Serialize, Deserialize, PartialEq, Eq, Clone)] | ||
| #[serde(transparent)] | ||
| pub struct NameMapping { | ||
| /// Holds mapped fields |
Contributor
There was a problem hiding this comment.
Seems we lack a MappedFields field like java one
| } | ||
|
|
||
| /// Applies the name mapping to the given schema. | ||
| pub fn apply_name_mapping(schema: &Schema, mapping: &NameMapping) -> Result<Type> { |
Contributor
There was a problem hiding this comment.
I'm confusing about this method, is there any case to demonstrate its usage?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Added
NameMappingimplementation. Includes updating, creating, and applying to other schema.Are these changes tested?