File tree Expand file tree Collapse file tree 2 files changed +1
-4
lines changed Expand file tree Collapse file tree 2 files changed +1
-4
lines changed Original file line number Diff line number Diff line change @@ -425,7 +425,7 @@ impl SchemaWithPartnerVisitor<ArrayRef> for ArrowArrayToIcebergStructConverter {
425425 }
426426}
427427
428- /// TODO(feniljain)
428+ /// Partner type representing accessing and walking arrow arrays alongside iceberg schema
429429pub struct ArrowArrayAccessor ;
430430
431431impl PartnerAccessor < ArrayRef > for ArrowArrayAccessor {
Original file line number Diff line number Diff line change @@ -317,8 +317,6 @@ impl MinMaxColAggregator {
317317 }
318318}
319319
320- // TODO(feniljain): Think do we need to add nan_value_counts to `parquet_files_to_data_files` and
321- // `parquet_to_data_file_builder` too?
322320impl ParquetWriter {
323321 /// Converts parquet files to data files
324322 #[ allow( dead_code) ]
@@ -525,7 +523,6 @@ impl FileWriter for ParquetWriter {
525523
526524 self . current_row_num += batch. num_rows ( ) ;
527525
528- // TODO(feniljain): Confirm if this `clone` is okay to perform
529526 let batch_c = batch. clone ( ) ;
530527 self . nan_value_count_visitor . compute ( self . schema . clone ( ) , batch_c) ?;
531528
You can’t perform that action at this time.
0 commit comments