Skip to content

Commit e9b557d

Browse files
committed
chore: remove TODOs
1 parent d87cf00 commit e9b557d

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

crates/iceberg/src/arrow/value.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -425,7 +425,7 @@ impl SchemaWithPartnerVisitor<ArrayRef> for ArrowArrayToIcebergStructConverter {
425425
}
426426
}
427427

428-
/// TODO(feniljain)
428+
/// Partner type representing accessing and walking arrow arrays alongside iceberg schema
429429
pub struct ArrowArrayAccessor;
430430

431431
impl PartnerAccessor<ArrayRef> for ArrowArrayAccessor {

crates/iceberg/src/writer/file_writer/parquet_writer.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -317,8 +317,6 @@ impl MinMaxColAggregator {
317317
}
318318
}
319319

320-
// TODO(feniljain): Think do we need to add nan_value_counts to `parquet_files_to_data_files` and
321-
// `parquet_to_data_file_builder` too?
322320
impl ParquetWriter {
323321
/// Converts parquet files to data files
324322
#[allow(dead_code)]
@@ -525,7 +523,6 @@ impl FileWriter for ParquetWriter {
525523

526524
self.current_row_num += batch.num_rows();
527525

528-
// TODO(feniljain): Confirm if this `clone` is okay to perform
529526
let batch_c = batch.clone();
530527
self.nan_value_count_visitor.compute(self.schema.clone(), batch_c)?;
531528

0 commit comments

Comments
 (0)