chore: fix edition 2024 compile errors (#998)

Signed-off-by: xxchan <[email protected]>

Author: xxchan

crates/iceberg/src/arrow/record_batch_transformer.rs

@@ -140,8 +140,8 @@ impl RecordBatchTransformer {
         Ok(match &self.batch_transform {
             Some(BatchTransform::PassThrough) => record_batch,
             Some(BatchTransform::Modify {
-                ref target_schema,
-                ref operations,
+                target_schema,
+                operations,
             }) => {
                 let options = RecordBatchOptions::default()
                     .with_match_field_names(false)
@@ -294,7 +294,7 @@ impl RecordBatchTransformer {
                     Error::new(ErrorKind::Unexpected, "Field not found in snapshot schema")
                 )?;
 
-                let default_value = if let Some(ref iceberg_default_value) =
+                let default_value = if let Some(iceberg_default_value) =
                     &iceberg_field.initial_default
                 {
                     let Literal::Primitive(primitive_literal) = iceberg_default_value else {

crates/iceberg/src/scan.rs

@@ -509,8 +509,8 @@ impl TableScan {
 
         if let Some(ref bound_predicates) = manifest_entry_context.bound_predicates {
             let BoundPredicates {
-                ref snapshot_bound_predicate,
-                ref partition_bound_predicate,
+                snapshot_bound_predicate,
+                partition_bound_predicate,
             } = bound_predicates.as_ref();
 
             let expression_evaluator_cache =
@@ -733,7 +733,7 @@ impl PlanContext {
         manifest_list: Arc<ManifestList>,
         tx_data: Sender<ManifestEntryContext>,
         delete_file_idx_and_tx: Option<(DeleteFileIndex, Sender<ManifestEntryContext>)>,
-    ) -> Result<Box<impl Iterator<Item = Result<ManifestFileContext>>>> {
+    ) -> Result<Box<impl Iterator<Item = Result<ManifestFileContext>> + 'static>> {
         let manifest_files = manifest_list.entries().iter();
 
         // TODO: Ideally we could ditch this intermediate Vec as we return an iterator.