From 3e781d0397e60150ef16ad710a737e4678132dff Mon Sep 17 00:00:00 2001 From: Fokko Driesprong Date: Sun, 3 Aug 2025 22:17:58 +0200 Subject: [PATCH 1/5] Debug CI --- .github/workflows/python-ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/python-ci.yml b/.github/workflows/python-ci.yml index c8cdbcc58a..1c94c571f5 100644 --- a/.github/workflows/python-ci.yml +++ b/.github/workflows/python-ci.yml @@ -65,9 +65,9 @@ jobs: - name: Run linters run: make lint - name: Run unit tests with coverage - run: COVERAGE=1 make test - - name: Generate coverage report (85%) # Coverage threshold should only increase over time — never decrease it! - run: COVERAGE_FAIL_UNDER=85 make coverage-report + run: make test +# - name: Generate coverage report (85%) # Coverage threshold should only increase over time — never decrease it! +# run: COVERAGE_FAIL_UNDER=85 make coverage-report integration-test: runs-on: ubuntu-22.04 From fa7382f706dd035fea8cb59aa4fe6b7f58d54600 Mon Sep 17 00:00:00 2001 From: Fokko Driesprong Date: Sun, 3 Aug 2025 22:58:31 +0200 Subject: [PATCH 2/5] Add ls --- .github/workflows/python-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/python-ci.yml b/.github/workflows/python-ci.yml index 1c94c571f5..41511a5205 100644 --- a/.github/workflows/python-ci.yml +++ b/.github/workflows/python-ci.yml @@ -61,7 +61,7 @@ jobs: - name: Install system dependencies run: sudo apt-get update && sudo apt-get install -y libkrb5-dev # for kerberos - name: Install - run: make install-dependencies + run: make install-dependencies && ls -lah pyiceberg/avro/ - name: Run linters run: make lint - name: Run unit tests with coverage From 2fd1c26922c8cbc743e3a6a36dac264939d1e8a2 Mon Sep 17 00:00:00 2001 From: Fokko Driesprong Date: Sun, 3 Aug 2025 23:18:11 +0200 Subject: [PATCH 3/5] Disable CI --- .github/workflows/python-ci.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/python-ci.yml b/.github/workflows/python-ci.yml index 41511a5205..84902b19c8 100644 --- a/.github/workflows/python-ci.yml +++ b/.github/workflows/python-ci.yml @@ -56,8 +56,6 @@ jobs: - uses: actions/setup-python@v5 with: python-version: ${{ matrix.python }} - cache: poetry - cache-dependency-path: ./poetry.lock - name: Install system dependencies run: sudo apt-get update && sudo apt-get install -y libkrb5-dev # for kerberos - name: Install From 379e4e2f86946d7511631d6ad804af7f632379b6 Mon Sep 17 00:00:00 2001 From: Fokko Driesprong Date: Sun, 3 Aug 2025 23:18:30 +0200 Subject: [PATCH 4/5] Revert other stuff --- .github/workflows/python-ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/python-ci.yml b/.github/workflows/python-ci.yml index 84902b19c8..5d3bdef851 100644 --- a/.github/workflows/python-ci.yml +++ b/.github/workflows/python-ci.yml @@ -59,13 +59,13 @@ jobs: - name: Install system dependencies run: sudo apt-get update && sudo apt-get install -y libkrb5-dev # for kerberos - name: Install - run: make install-dependencies && ls -lah pyiceberg/avro/ + run: make install-dependencies - name: Run linters run: make lint - name: Run unit tests with coverage run: make test -# - name: Generate coverage report (85%) # Coverage threshold should only increase over time — never decrease it! -# run: COVERAGE_FAIL_UNDER=85 make coverage-report + - name: Generate coverage report (85%) # Coverage threshold should only increase over time — never decrease it! + run: COVERAGE_FAIL_UNDER=85 make coverage-report integration-test: runs-on: ubuntu-22.04 From 62c43230e7fefd31894b9e55841f9f2454286ae0 Mon Sep 17 00:00:00 2001 From: Fokko Driesprong Date: Sun, 3 Aug 2025 23:18:59 +0200 Subject: [PATCH 5/5] Enable coverage --- .github/workflows/python-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/python-ci.yml b/.github/workflows/python-ci.yml index 5d3bdef851..3ae0f7122f 100644 --- a/.github/workflows/python-ci.yml +++ b/.github/workflows/python-ci.yml @@ -63,7 +63,7 @@ jobs: - name: Run linters run: make lint - name: Run unit tests with coverage - run: make test + run: COVERAGE=1 make test - name: Generate coverage report (85%) # Coverage threshold should only increase over time — never decrease it! run: COVERAGE_FAIL_UNDER=85 make coverage-report