fix snapshot schema issue: wrong usage of walrus operator #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
reviewed
Dec 13, 2023
Co-authored-by: Fokko Driesprong <[email protected]>
Fokko
approved these changes
Dec 13, 2023
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Looks good, thanks @tonyps1223 for fixing this! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When given the first snapshot-id of the table, the schema got should have schema_id = 0.
But under origin code's conditional statements, the use of walrus operator will cause the condition that when schema_id = 0, it will not pass the if statement, thus the schema will not change.