From 55e209c0fed2d83aa420d02e6cfde7cbdb292602 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?D=C3=A1vid=20Paksy?= Date: Tue, 14 Oct 2025 16:43:55 +0200 Subject: [PATCH 1/2] HBASE-29659 Use separate webjar dependencies for website instead of reflow-default-webdeps Reason: reflow-default-webdeps causes a Maven ERROR and Yetus build considers the site build to be broken. Turned off these features in the site skin which we don't need and would require to add more JavaScript: - highlight.js, - lightbox.js, - smooth scrolling. Improved code blocks style to look good without highlight.js. Also extracted MathJax.js and fontawesome (needed for RefGuide) versions to Maven properties. --- pom.xml | 139 +++++++++++++++++++++++++++----- src/site/resources/css/site.css | 2 + src/site/site.xml | 5 +- 3 files changed, 124 insertions(+), 22 deletions(-) diff --git a/pom.xml b/pom.xml index d60099650214..e56bc34f5bda 100644 --- a/pom.xml +++ b/pom.xml @@ -960,6 +960,17 @@ 2.44.4 3.12.0 2.3.3 + 1.2.1 + + 4.4.0 + 1.16.0 + 3.4.1 + 4.4.1 + 3.2.2 + 5.12.0 + + 4.7.0 + 2.7.0 0.27 1.11.0 @@ -2795,7 +2806,7 @@ org.webjars font-awesome - 4.7.0 + ${refguide.fontawesome.version} jar true **/css/font-awesome.css, @@ -2808,7 +2819,7 @@ org.webjars MathJax - 2.7.0 + ${refguide.mathjax.version} jar true **/MathJax.js, @@ -2846,22 +2857,56 @@ - io.github.devacfr.maven.skins - reflow-default-webdeps - ${reflow-maven-skin.version} - jar - false - **/css/bootstrap.min.css, - **/css/themes/litera/bootstrap.min.css, - **/css/fontawesome/*, - **/css/fontawesome/webfonts/*, - **/js/*.js, - **/js/languages/*, - **/js/styles/github.min.css, - **/js/styles/default.min.css + org.webjars + bootstrap + ${site.bootstrap.version} + **/js/bootstrap.min.js + + + org.webjars + popper.js + ${site.popperjs.version} + **/umd/popper.min.js + + + org.webjars + jquery + ${site.jquery.version} + **/jquery.min.js + + + org.webjars + anchorjs + ${site.anchorjs.version} + **/anchor.min.js + + + org.webjars + font-awesome + ${site.fontawesome.version} + **/css/all.min.css,**/webfonts/* - ${project.build.directory}/site + ${project.build.directory} + + + + + + com.googlecode.maven-download-plugin + download-maven-plugin + ${maven-download-plugin.version} + + + download-litera-bootstrap-theme + + wget + + pre-site + + https://stackpath.bootstrapcdn.com/bootswatch/${site.bootswatch.version}/litera/bootstrap.min.css + ${project.build.directory}/site/css/themes/litera + bootstrap.min.css @@ -3012,6 +3057,60 @@ + + copy-website-resources + + copy-resources + + pre-site + + ${project.build.outputDirectory} + + + ${project.build.directory}/META-INF/resources/webjars/bootstrap/${site.bootstrap.version}/js + ${project.build.directory}/site/js + + bootstrap.min.js + + + + ${project.build.directory}/META-INF/resources/webjars/popper.js/${site.popperjs.version}/umd + ${project.build.directory}/site/js + + popper.min.js + + + + ${project.build.directory}/META-INF/resources/webjars/jquery/${site.jquery.version} + ${project.build.directory}/site/js + + jquery.min.js + + + + ${project.build.directory}/META-INF/resources/webjars/anchorjs/${site.anchorjs.version} + ${project.build.directory}/site/js + + anchor.min.js + + + + ${project.build.directory}/META-INF/resources/webjars/font-awesome/${site.fontawesome.version}/css + ${project.build.directory}/site/css/fontawesome + + all.min.css + + + + ${project.build.directory}/META-INF/resources/webjars/font-awesome/${site.fontawesome.version} + ${project.build.directory}/site/css + + webfonts/* + + + + + @@ -3043,17 +3142,17 @@ - + - + - + @@ -3066,7 +3165,7 @@ - + diff --git a/src/site/resources/css/site.css b/src/site/resources/css/site.css index 17faa5b035b6..cece2e3a1504 100644 --- a/src/site/resources/css/site.css +++ b/src/site/resources/css/site.css @@ -30,8 +30,10 @@ /** Restore earlier code block styles. */ pre { + background-color: #f5f5f5; border-radius: 6px; border: 1px solid rgba(0, 0, 0, 0.15); + padding: 10px; } footer { diff --git a/src/site/site.xml b/src/site/site.xml index 58a887632d0f..bb71739e419d 100644 --- a/src/site/site.xml +++ b/src/site/site.xml @@ -35,7 +35,6 @@ true - true Apache HBase Project Project Information @@ -43,7 +42,9 @@ ASF bootswatch-litera - true + false + false + false ]]> index.html From 7befc9ca126e715983cff8451ec07e7d5e472795 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?D=C3=A1vid=20Paksy?= Date: Wed, 15 Oct 2025 09:45:10 +0200 Subject: [PATCH 2/2] HBASE-29659 Use webjar for bootswatch instead of downloading it from a URL. We prefer maven resource as it can be cached locally. --- pom.xml | 32 +++++++++++++------------------- 1 file changed, 13 insertions(+), 19 deletions(-) diff --git a/pom.xml b/pom.xml index e56bc34f5bda..5669c590d604 100644 --- a/pom.xml +++ b/pom.xml @@ -2862,6 +2862,12 @@ ${site.bootstrap.version} **/js/bootstrap.min.js + + org.webjars.npm + bootswatch + ${site.bootswatch.version} + **/litera/bootstrap.min.css + org.webjars popper.js @@ -2892,25 +2898,6 @@ - - com.googlecode.maven-download-plugin - download-maven-plugin - ${maven-download-plugin.version} - - - download-litera-bootstrap-theme - - wget - - pre-site - - https://stackpath.bootstrapcdn.com/bootswatch/${site.bootswatch.version}/litera/bootstrap.min.css - ${project.build.directory}/site/css/themes/litera - bootstrap.min.css - - - - @@ -3073,6 +3060,13 @@ bootstrap.min.js + + ${project.build.directory}/META-INF/resources/webjars/bootswatch/${site.bootswatch.version}/dist/litera + ${project.build.directory}/site/css/themes/litera + + bootstrap.min.css + + ${project.build.directory}/META-INF/resources/webjars/popper.js/${site.popperjs.version}/umd ${project.build.directory}/site/js