From 21ebe8a5f5de59f0d0cf76ec2e776017a9088f91 Mon Sep 17 00:00:00 2001 From: Wellington Ramos Chevreuil Date: Thu, 18 May 2023 15:59:59 +0100 Subject: [PATCH 1/2] HBASE-27874 Problem in flakey generated report causes pre-commit run to fail Change-Id: I68aca8c5216e03120a848ee9bfc020a9b5cdcbc2 --- dev-support/flaky-tests/findHangingTests.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dev-support/flaky-tests/findHangingTests.py b/dev-support/flaky-tests/findHangingTests.py index bb0a9a5be619..9346320b4419 100755 --- a/dev-support/flaky-tests/findHangingTests.py +++ b/dev-support/flaky-tests/findHangingTests.py @@ -62,7 +62,7 @@ def get_bad_tests(console_url): for line in response.content.decode("utf-8").splitlines(): result1 = re.findall("Running org.apache.hadoop.hbase.(.*)", line) if len(result1) == 1: - test_case = result1[0] + test_case = result1[0].split("WARNING")[0].strip() if test_case in all_tests_set: print(("ERROR! Multiple tests with same name '{}'. Might get wrong results " "for this test.".format(test_case))) @@ -71,7 +71,7 @@ def get_bad_tests(console_url): all_tests_set.add(test_case) result2 = re.findall("Tests run:.*?- in org.apache.hadoop.hbase.(.*)", line) if len(result2) == 1: - test_case = result2[0] + test_case = result2[0].split("WARNING")[0].strip() if "FAILURE!" in line: failed_tests_set.add(test_case) if test_case not in hanging_tests_set: From 7f55a2ccb8b562669022c5df314800bdb969f996 Mon Sep 17 00:00:00 2001 From: Wellington Ramos Chevreuil Date: Fri, 19 May 2023 16:19:58 +0100 Subject: [PATCH 2/2] added comments Change-Id: Ib9165a994185f364387f78087a5585cac5ee562e --- dev-support/flaky-tests/findHangingTests.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dev-support/flaky-tests/findHangingTests.py b/dev-support/flaky-tests/findHangingTests.py index 9346320b4419..e07638ac7d78 100755 --- a/dev-support/flaky-tests/findHangingTests.py +++ b/dev-support/flaky-tests/findHangingTests.py @@ -62,6 +62,7 @@ def get_bad_tests(console_url): for line in response.content.decode("utf-8").splitlines(): result1 = re.findall("Running org.apache.hadoop.hbase.(.*)", line) if len(result1) == 1: + # Sometimes the maven build output might have some malformed lines. See HBASE-27874 test_case = result1[0].split("WARNING")[0].strip() if test_case in all_tests_set: print(("ERROR! Multiple tests with same name '{}'. Might get wrong results " @@ -71,6 +72,7 @@ def get_bad_tests(console_url): all_tests_set.add(test_case) result2 = re.findall("Tests run:.*?- in org.apache.hadoop.hbase.(.*)", line) if len(result2) == 1: + # Sometimes the maven build output might have some malformed lines. See HBASE-27874 test_case = result2[0].split("WARNING")[0].strip() if "FAILURE!" in line: failed_tests_set.add(test_case)