Skip to content

HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (2.1) #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2019
Merged

HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (2.1) #427

merged 1 commit into from
Jul 30, 2019

Conversation

@anmolnar
Copy link
Contributor

Added caller info to grant / revoke audit log events.

branch-2.1 version

@anmolnar anmolnar changed the title HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (2.1) Jul 29, 2019
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 47 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
+1 mvninstall 307 branch-2.1 passed
+1 compile 53 branch-2.1 passed
+1 checkstyle 77 branch-2.1 passed
+1 shadedjars 240 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 31 branch-2.1 passed
0 spotbugs 166 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 165 branch-2.1 passed
_ Patch Compile Tests _
+1 mvninstall 290 the patch passed
+1 compile 54 the patch passed
+1 javac 54 the patch passed
+1 checkstyle 74 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 247 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1205 Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1 javadoc 33 the patch passed
+1 findbugs 175 the patch passed
_ Other Tests _
+1 unit 8015 hbase-server in the patch passed.
+1 asflicense 23 The patch does not generate ASF License warnings.
11421
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/1/artifact/out/Dockerfile
GITHUB PR #427
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux a5f1a79884a5 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-427/out/precommit/personality/provided.sh
git revision branch-2.1 / 31c99ff
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/1/testReport/
Max. process+thread count 4441 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 79 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
-1 mvninstall 133 root in branch-2.1 failed.
-1 compile 37 hbase-server in branch-2.1 failed.
+1 checkstyle 72 branch-2.1 passed
-1 shadedjars 163 branch has 24 errors when building our shaded downstream artifacts.
+1 javadoc 30 branch-2.1 passed
0 spotbugs 230 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 36 hbase-server in branch-2.1 failed.
_ Patch Compile Tests _
-1 mvninstall 134 root in the patch failed.
-1 compile 35 hbase-server in the patch failed.
-1 javac 35 hbase-server in the patch failed.
+1 checkstyle 70 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
-1 shadedjars 162 patch has 24 errors when building our shaded downstream artifacts.
-1 hadoopcheck 95 The patch causes 24 errors with Hadoop v2.7.7.
-1 hadoopcheck 190 The patch causes 24 errors with Hadoop v2.8.5.
-1 hadoopcheck 291 The patch causes 24 errors with Hadoop v3.0.3.
-1 hadoopcheck 389 The patch causes 24 errors with Hadoop v3.1.2.
+1 javadoc 30 the patch passed
-1 findbugs 35 hbase-server in the patch failed.
_ Other Tests _
-1 unit 35 hbase-server in the patch failed.
+1 asflicense 10 The patch does not generate ASF License warnings.
1521
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/Dockerfile
GITHUB PR #427
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 32c46b39628c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-427/out/precommit/personality/provided.sh
git revision branch-2.1 / d45b2d4
Default Java 1.8.0_181
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/branch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/branch-compile-hbase-server.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/branch-shadedjars.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/branch-findbugs-hbase-server.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/patch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/patch-compile-hbase-server.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/patch-compile-hbase-server.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/patch-shadedjars.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/patch-javac-2.7.7.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/patch-javac-3.0.3.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/patch-javac-3.1.2.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/patch-findbugs-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/testReport/
Max. process+thread count 96 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/2/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 71 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
-1 mvninstall 79 root in branch-2.1 failed.
-1 compile 12 hbase-server in branch-2.1 failed.
-1 checkstyle 9 The patch fails to run checkstyle in hbase-server
-1 shadedjars 169 branch has 36 errors when building our shaded downstream artifacts.
-1 javadoc 8 hbase-server in branch-2.1 failed.
0 spotbugs 187 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 8 hbase-server in branch-2.1 failed.
_ Patch Compile Tests _
-1 mvninstall 71 root in the patch failed.
-1 compile 8 hbase-server in the patch failed.
-1 javac 8 hbase-server in the patch failed.
-1 checkstyle 6 The patch fails to run checkstyle in hbase-server
+1 whitespace 0 The patch has no whitespace issues.
-1 shadedjars 171 patch has 36 errors when building our shaded downstream artifacts.
-1 hadoopcheck 65 The patch causes 10 errors with Hadoop v2.7.7.
-1 hadoopcheck 133 The patch causes 10 errors with Hadoop v2.8.5.
-1 hadoopcheck 204 The patch causes 10 errors with Hadoop v3.0.3.
-1 hadoopcheck 275 The patch causes 10 errors with Hadoop v3.1.2.
-1 javadoc 10 hbase-server in the patch failed.
-1 findbugs 9 hbase-server in the patch failed.
_ Other Tests _
-1 unit 10 hbase-server in the patch failed.
+1 asflicense 10 The patch does not generate ASF License warnings.
1004
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/Dockerfile
GITHUB PR #427
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux b1fb3c3ba2e7 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-427/out/precommit/personality/provided.sh
git revision branch-2.1 / 65a6b27
Default Java 1.8.0_181
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/branch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/branch-compile-hbase-server.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out//home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-427/out/maven-branch-checkstyle-hbase-server.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/branch-shadedjars.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/branch-javadoc-hbase-server.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/branch-findbugs-hbase-server.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/patch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/patch-compile-hbase-server.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/patch-compile-hbase-server.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out//home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-427/out/maven-patch-checkstyle-hbase-server.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/patch-shadedjars.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/patch-javac-2.7.7.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/patch-javac-3.0.3.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/patch-javac-3.1.2.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/patch-javadoc-hbase-server.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/patch-findbugs-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/testReport/
Max. process+thread count 76 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/3/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@petersomogyi petersomogyi merged commit 29f8e19 into apache:branch-2.1 Jul 30, 2019
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 44 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
+1 mvninstall 270 branch-2.1 passed
+1 compile 52 branch-2.1 passed
+1 checkstyle 72 branch-2.1 passed
+1 shadedjars 229 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 32 branch-2.1 passed
0 spotbugs 158 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 156 branch-2.1 passed
_ Patch Compile Tests _
+1 mvninstall 279 the patch passed
+1 compile 50 the patch passed
+1 javac 50 the patch passed
+1 checkstyle 74 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 232 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1143 Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1 javadoc 32 the patch passed
+1 findbugs 166 the patch passed
_ Other Tests _
-1 unit 7830 hbase-server in the patch failed.
+1 asflicense 29 The patch does not generate ASF License warnings.
11035
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/5/artifact/out/Dockerfile
GITHUB PR #427
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 1542020d4ef8 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-427/out/precommit/personality/provided.sh
git revision branch-2.1 / 11b647b
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/5/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/5/testReport/
Max. process+thread count 5006 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/5/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 93 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.1 Compile Tests _
+1 mvninstall 292 branch-2.1 passed
+1 compile 51 branch-2.1 passed
+1 checkstyle 75 branch-2.1 passed
+1 shadedjars 236 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 31 branch-2.1 passed
0 spotbugs 153 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 150 branch-2.1 passed
_ Patch Compile Tests _
+1 mvninstall 265 the patch passed
+1 compile 49 the patch passed
+1 javac 49 the patch passed
+1 checkstyle 71 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 228 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1130 Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1 javadoc 32 the patch passed
+1 findbugs 155 the patch passed
_ Other Tests _
-1 unit 15339 hbase-server in the patch failed.
+1 asflicense 22 The patch does not generate ASF License warnings.
18559
Reason Tests
Failed junit tests hadoop.hbase.replication.TestReplicationKillSlaveRSWithSeparateOldWALs
hadoop.hbase.replication.TestReplicationSmallTests
hadoop.hbase.replication.TestReplicationKillSlaveRS
hadoop.hbase.client.TestAdmin1
hadoop.hbase.master.procedure.TestProcedurePriority
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/4/artifact/out/Dockerfile
GITHUB PR #427
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 521bc44836eb 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-427/out/precommit/personality/provided.sh
git revision branch-2.1 / efead31
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/4/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/4/testReport/
Max. process+thread count 5453 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-427/4/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petersomogyi petersomogyi petersomogyi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anmolnar @Apache-HBase @petersomogyi