Skip to content

HBASE-26430 Increase log level in DefaultHeapMemoryTuner from DEBUG to INFO #3820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 9, 2021
Merged

HBASE-26430 Increase log level in DefaultHeapMemoryTuner from DEBUG to INFO #3820

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adc2f3d
HBASE-26430 Increase log level in DefaultHeapMemoryTuner from DEBUG t…
apurtell Nov 6, 2021
81e68c4
Adjust log level based on interest
apurtell Nov 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultHeapMemoryTuner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,8 @@ public TunerResult tune(TunerContext context) {
// Ignoring the first few tuner periods
ignoreInitialPeriods++;
rollingStatsForTunerSteps.insertDataValue(0);
LOG.info("Ignoring initial tuning periods: {} so far, {} to ignore", ignoreInitialPeriods,
numPeriodsToIgnore);
return NO_OP_TUNER_RESULT;
}
StepDirection newTuneDirection = getTuneDirection(context);
Expand Down Expand Up @@ -252,12 +254,15 @@ private StepDirection getTuneDirection(TunerContext context) {
if (earlyMemstoreSufficientCheck && earlyBlockCacheSufficientCheck) {
// Both memstore and block cache memory seems to be sufficient. No operation required.
newTuneDirection = StepDirection.NEUTRAL;
tunerLog.append("Going to do nothing because no changes are needed.");
} else if (earlyMemstoreSufficientCheck) {
// Increase the block cache size and corresponding decrease in memstore size.
newTuneDirection = StepDirection.INCREASE_BLOCK_CACHE_SIZE;
tunerLog.append("Going to increase the block cache size.");
} else if (earlyBlockCacheSufficientCheck) {
// Increase the memstore size and corresponding decrease in block cache size.
newTuneDirection = StepDirection.INCREASE_MEMSTORE_SIZE;
tunerLog.append("Going to increase the memstore size.");
} else {
// Early checks for sufficient memory failed. Tuning memory based on past statistics.
// Boolean indicator to show if we need to revert previous step or not.
Expand Down Expand Up @@ -347,8 +352,17 @@ private StepDirection getTuneDirection(TunerContext context) {
}
}
}
if (LOG.isDebugEnabled()) {
LOG.debug(tunerLog.toString());
// Log NEUTRAL decisions at DEBUG, because they are the most frequent and not that interesting.
// Log other decisions at INFO because they are making meaningful operational changes.
switch (newTuneDirection) {
case NEUTRAL:
if (LOG.isDebugEnabled()) {
LOG.debug(tunerLog.toString());
}
break;
default:
LOG.info(tunerLog.toString());
break;
}
return newTuneDirection;
}
Expand Down