From 7a173a95da20fd81bfe789f8e0ab680fabb370f7 Mon Sep 17 00:00:00 2001 From: Duo Zhang Date: Sun, 28 Feb 2021 09:49:41 +0800 Subject: [PATCH] HBASE-25617 Revisit the span names --- .../org/apache/hadoop/hbase/client/AsyncConnectionImpl.java | 4 ++-- .../org/apache/hadoop/hbase/client/AsyncRegionLocator.java | 2 +- .../org/apache/hadoop/hbase/client/ConnectionFactory.java | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java index 9c02bc39f202..78fe8a8a76cb 100644 --- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java +++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java @@ -424,12 +424,12 @@ public CompletableFuture getHbck() { } }); return future; - }, getClass().getName() + ".getHbck"); + }, "AsyncConnection.getHbck"); } @Override public Hbck getHbck(ServerName masterServer) throws IOException { - Span span = TraceUtil.createSpan(getClass().getName() + ".getHbck") + Span span = TraceUtil.createSpan("AsyncConnection.getHbck") .setAttribute(TraceUtil.SERVER_NAME_KEY, masterServer.getServerName()); try (Scope scope = span.makeCurrent()) { // we will not create a new connection when creating a new protobuf stub, and for hbck there diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRegionLocator.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRegionLocator.java index 9219c95c15e3..716598af432f 100644 --- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRegionLocator.java +++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRegionLocator.java @@ -98,7 +98,7 @@ private boolean isMeta(TableName tableName) { private CompletableFuture tracedLocationFuture(Supplier> action, Function> getRegionNames, TableName tableName, String methodName) { - Span span = createTableSpan(getClass().getSimpleName() + "." + methodName, tableName); + Span span = createTableSpan("AsyncRegionLocator." + methodName, tableName); try (Scope scope = span.makeCurrent()) { CompletableFuture future = action.get(); FutureUtils.addListener(future, (resp, error) -> { diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionFactory.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionFactory.java index bdf438241ca5..a3cf55715bdf 100644 --- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionFactory.java +++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionFactory.java @@ -305,6 +305,6 @@ public static CompletableFuture createAsyncConnection(Configura } }); return future; - }, ConnectionFactory.class.getSimpleName() + ".createAsyncConnection"); + }, "ConnectionFactory.createAsyncConnection"); } }