Skip to content

HBASE-25329 Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time #2762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2021
Merged

HBASE-25329 Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time #2762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...p-compat/src/main/java/org/apache/hadoop/hbase/master/MetricsAssignmentManagerSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public interface MetricsAssignmentManagerSource extends BaseSource {
/**
* Description
*/
String METRICS_DESCRIPTION = "Metrics about HBase master assingment manager.";
String METRICS_DESCRIPTION = "Metrics about HBase master assignment manager.";

String RIT_COUNT_NAME = "ritCount";
String RIT_COUNT_OVER_THRESHOLD_NAME = "ritCountOverThreshold";
Expand Down
14 changes: 14 additions & 0 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3538,18 +3538,32 @@ public void updateRegionsInTransitionMetrics() {
int totalRITs = 0;
int totalRITsOverThreshold = 0;
long oldestRITTime = 0;
Map<String, RegionState> ritsOverThreshold = null;
int ritThreshold = this.server.getConfiguration().
getInt(HConstants.METRICS_RIT_STUCK_WARNING_THRESHOLD, 60000);
for (RegionState state: regionStates.getRegionsInTransition()) {
totalRITs++;
long ritTime = currentTime - state.getStamp();
if (ritTime > ritThreshold) { // more than the threshold
totalRITsOverThreshold++;
if (ritsOverThreshold == null) {
ritsOverThreshold = new HashMap<>();
}
ritsOverThreshold.put(state.getRegion().getEncodedName(), state);
}
if (oldestRITTime < ritTime) {
oldestRITTime = ritTime;
}
}
if (LOG.isDebugEnabled() && ritsOverThreshold != null && !ritsOverThreshold.isEmpty()) {
StringBuilder sb = new StringBuilder();
for (Map.Entry<String, RegionState> rit: ritsOverThreshold.entrySet()) {
sb.append(rit.getKey()).append(":")
.append(rit.getValue().getState().name()).append("\n");
}
sb.delete(sb.length()-1, sb.length());
LOG.debug("RITs over threshold: " + sb.toString());
}
if (this.metricsAssignmentManager != null) {
this.metricsAssignmentManager.updateRITOldestAge(oldestRITTime);
this.metricsAssignmentManager.updateRITCount(totalRITs);
Expand Down