HBASE-22459 Expose store reader reference count #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
Apache9
requested changes
May 23, 2019
| @Override | ||
| public int getStoreRefCount() { | ||
| return this.storeEngine.getStoreFileManager().getStorefiles().stream() | ||
| .filter(sf -> { return sf.getReader() != null; }) |
There was a problem hiding this comment.
sf -> sf.getReader() != null is enough?
There was a problem hiding this comment.
Ok. This style is new to me
| return this.storeEngine.getStoreFileManager().getStorefiles().stream() | ||
| .filter(sf -> { return sf.getReader() != null; }) | ||
| .filter(HStoreFile::isHFile) | ||
| .mapToInt(sf -> sf.getRefCount()) |
There was a problem hiding this comment.
HStoreFile::getRefCount is better?
| /** | ||
| * @return Reference count over store | ||
| */ | ||
| int getStoreRefCount(); |
There was a problem hiding this comment.
So here we also expose this value to CP, not only through metrics?
There was a problem hiding this comment.
I think it would be good to have this in the interface to avoid some casting but is not required probably
There was a problem hiding this comment.
If you mean this code sniff
for (Store store : region.stores.values()) {
tempNumStoreFiles += store.getStorefilesCount();
tempStoreRefCount += store.getStoreRefCount();
tempMemstoreSize += store.getMemStoreSize().getDataSize();
tempStoreFileSize += store.getStorefilesSize();
OptionalLong storeMaxStoreFileAge = store.getMaxStoreFileAge();
Actually you can just change the for (Store store : region.stores.values()) { to for (HStore store : region.stores.values()) {, as the region is a HRegion.
|
Bah need to fix TestStorageClusterStatusModel and maybe the other one. Back soon |
|
💔 -1 overall
This message was automatically generated. |
Apache9
requested changes
May 24, 2019
| /** | ||
| * @return Reference count over store | ||
| */ | ||
| int getStoreRefCount(); |
There was a problem hiding this comment.
If you mean this code sniff
for (Store store : region.stores.values()) {
tempNumStoreFiles += store.getStorefilesCount();
tempStoreRefCount += store.getStoreRefCount();
tempMemstoreSize += store.getMemStoreSize().getDataSize();
tempStoreFileSize += store.getStorefilesSize();
OptionalLong storeMaxStoreFileAge = store.getMaxStoreFileAge();
Actually you can just change the for (Store store : region.stores.values()) { to for (HStore store : region.stores.values()) {, as the region is a HRegion.
|
Other than Duo's comment , LGTM. +1 |
|
No problem, will remove from Store and leave in HStore only. Back soon. |
|
TestMasterReplication issue does not seem related, but will check |
|
Updated patch removes changes to Store. |
|
Last version of patch got a clean precommit run on the JIRA. No reason to think the interface change in the latest patch would affect that. |
|
💔 -1 overall
This message was automatically generated. |
Apache9
approved these changes
May 30, 2019
|
+1 |
asfgit
pushed a commit
that referenced
this pull request
May 30, 2019
asfgit
pushed a commit
that referenced
this pull request
May 30, 2019
infraio
pushed a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the reference count over a region's store file readers as a metric in region metrics and also as a new field in RegionLoad. This will make visible the reader reference count over all stores in the region to both metrics capture and anything that consumes ClusterStatus, like the shell's status command and the master UI.
Coprocessors that wrap scanners might leak them, which will leak readers. We log when this happens but in order to notice the increasing trend of reference counts you have to scrape log output. It would be better if this information is also available as a metric.