HBASE-27938 - fix checkstyle errors

Author: Prathyusha Garre

hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java

@@ -360,11 +360,14 @@ static boolean checkTable(Admin admin, TestOptions opts) throws IOException {
     // recreate the table when user has requested presplit or when existing
     // {RegionSplitPolicy,replica count} does not match requested, or when the
     // number of column families does not match requested.
-    if ((exists && opts.presplitRegions != DEFAULT_OPTS.presplitRegions
+    if (
+      (exists && opts.presplitRegions != DEFAULT_OPTS.presplitRegions
         && opts.presplitRegions != admin.getRegions(tableName).size())
-        || (!isReadCmd && desc != null && !StringUtils.equals(desc.getRegionSplitPolicyClassName(), opts.splitPolicy))
+        || (!isReadCmd && desc != null
+          && !StringUtils.equals(desc.getRegionSplitPolicyClassName(), opts.splitPolicy))
         || (!isReadCmd && desc != null && desc.getRegionReplication() != opts.replicas)
-        || (desc != null && desc.getColumnFamilyCount() != opts.families)) {
+        || (desc != null && desc.getColumnFamilyCount() != opts.families)
+    ) {
       needsDelete = true;
       // wait, why did it delete my table?!?
       LOG.debug(MoreObjects.toStringHelper("needsDelete").add("needsDelete", needsDelete)
@@ -786,11 +789,11 @@ public TestOptions(TestOptions that) {
       this.bufferSize = that.bufferSize;
       this.commandProperties = that.commandProperties;
     }
-    
+
     public Properties getCommandProperties() {
       return commandProperties;
     }
-    
+
     public int getCaching() {
       return this.caching;
     }
@@ -2586,7 +2589,7 @@ protected static void printUsage(final String shortName, final String message) {
       System.err.println(message);
     }
     System.err.print("Usage: hbase " + shortName);
-    System.err.println("  <OPTIONS> [-D<property=value>]* <command> <nclients>");
+    System.err.println("  <OPTIONS> [-D<property=value>]* <command|class> <nclients>");
     System.err.println();
     System.err.println("General Options:");
     System.err.println(
@@ -2686,7 +2689,10 @@ protected static void printUsage(final String shortName, final String message) {
     for (CmdDescriptor command : COMMANDS.values()) {
       System.err.println(String.format(" %-20s %s", command.getName(), command.getDescription()));
     }
-    System.err.println(String.format(" %-20s %s", "? extends Test", "Run custom implementation of provided Test present in classpath"));
+    System.err.println();
+    System.err.println("Class:");
+    System.err.println("To run any custom implementation of PerformanceEvaluation.Test, provide the classname of the implementaion class in place of command name and it will be loaded at runtime from classpath.:");
+    System.err.println("Please consider to contribute back this custom test impl into a builtin PE command for the benefit of the community");
     System.err.println();
     System.err.println("Args:");
     System.err.println(" nclients        Integer. Required. Total number of clients "
@@ -2987,14 +2993,15 @@ static TestOptions parseOpts(Queue<String> args) {
         String fileName = String.valueOf(cmd.substring(commandPropertiesFile.length()));
         Properties properties = new Properties();
         try {
-          properties.load(PerformanceEvaluation.class.getClassLoader().getResourceAsStream(fileName));
+          properties
+            .load(PerformanceEvaluation.class.getClassLoader().getResourceAsStream(fileName));
           opts.commandProperties = properties;
         } catch (IOException e) {
           LOG.error("Failed to load metricIds from properties file", e);
         }
         continue;
       }
-      
+
       validateParsedOpts(opts);
 
       if (isCommandClass(cmd)) {
@@ -3114,15 +3121,16 @@ private static boolean isCommandClass(String cmd) {
   private static boolean isCustomTestClass(String cmd) {
     Class<? extends Test> cmdClass;
     try {
-      cmdClass = (Class<? extends Test>) PerformanceEvaluation.class.getClassLoader().loadClass(cmd);
+      cmdClass =
+        (Class<? extends Test>) PerformanceEvaluation.class.getClassLoader().loadClass(cmd);
       addCommandDescriptor(cmdClass, cmd, "custom command");
       return true;
     } catch (Throwable th) {
       LOG.info("No class found for command: " + cmd, th);
       return false;
     }
   }
-  
+
   private static Class<? extends TestBase> determineCommandClass(String cmd) {
     CmdDescriptor descriptor = COMMANDS.get(cmd);
     return descriptor != null ? descriptor.getCmdClass() : null;