Skip to content

Commit f6f41c4

Browse files
authored
HBASE-28512 Update error prone to 2.26.1 (#5843)
Signed-off-by: Xin Sun <[email protected]>
1 parent 4c7d766 commit f6f41c4

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestHtmlQuoting.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import static org.junit.Assert.assertArrayEquals;
2121
import static org.junit.Assert.assertEquals;
2222
import static org.junit.Assert.assertFalse;
23+
import static org.junit.Assert.assertNull;
2324
import static org.junit.Assert.assertTrue;
2425

2526
import javax.servlet.http.HttpServletRequest;
@@ -94,7 +95,7 @@ public void testRequestQuoting() throws Exception {
9495
quoter.getParameterValues("x"));
9596

9697
Mockito.doReturn(null).when(mockReq).getParameterValues("x");
97-
assertArrayEquals("Test that missing parameters dont cause NPE for array", null,
98+
assertNull("Test that missing parameters dont cause NPE for array",
9899
quoter.getParameterValues("x"));
99100
}
100101
}

hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionInfo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,7 @@ public void testComparator() {
320320
b = RegionInfoBuilder.newBuilder(t).setStartKey(midway).build();
321321
assertTrue(a.compareTo(b) < 0);
322322
assertTrue(b.compareTo(a) > 0);
323-
assertEquals(a, a);
323+
assertTrue(a.equals(a));
324324
assertEquals(0, a.compareTo(a));
325325
a = RegionInfoBuilder.newBuilder(t).setStartKey(Bytes.toBytes("a"))
326326
.setEndKey(Bytes.toBytes("d")).build();

hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -536,7 +536,7 @@ public void testDeleteFamily() throws Exception {
536536

537537
get = new TGet(wrap(rowName));
538538
result = handler.get(table, get);
539-
assertArrayEquals(null, result.getRow());
539+
assertNull(result.getRow());
540540
assertEquals(0, result.getColumnValuesSize());
541541
}
542542

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -880,7 +880,7 @@
880880
-->
881881
<checkstyle.version>8.29</checkstyle.version>
882882
<exec.maven.version>3.1.0</exec.maven.version>
883-
<error-prone.version>2.16</error-prone.version>
883+
<error-prone.version>2.26.1</error-prone.version>
884884
<jamon.plugin.version>2.4.2</jamon.plugin.version>
885885
<lifecycle.mapping.version>1.0.0</lifecycle.mapping.version>
886886
<maven.antrun.version>1.8</maven.antrun.version>

0 commit comments

Comments
 (0)