Skip to content

Commit cb5c476

Browse files
authored
HBASE-25617 Revisit the span names (#2998)
Signed-off-by: Guanghao Zhang <[email protected]>
1 parent caa61b5 commit cb5c476

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -424,12 +424,12 @@ public CompletableFuture<Hbck> getHbck() {
424424
}
425425
});
426426
return future;
427-
}, getClass().getName() + ".getHbck");
427+
}, "AsyncConnection.getHbck");
428428
}
429429

430430
@Override
431431
public Hbck getHbck(ServerName masterServer) throws IOException {
432-
Span span = TraceUtil.createSpan(getClass().getName() + ".getHbck")
432+
Span span = TraceUtil.createSpan("AsyncConnection.getHbck")
433433
.setAttribute(TraceUtil.SERVER_NAME_KEY, masterServer.getServerName());
434434
try (Scope scope = span.makeCurrent()) {
435435
// we will not create a new connection when creating a new protobuf stub, and for hbck there

hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRegionLocator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ private boolean isMeta(TableName tableName) {
9898

9999
private <T> CompletableFuture<T> tracedLocationFuture(Supplier<CompletableFuture<T>> action,
100100
Function<T, List<String>> getRegionNames, TableName tableName, String methodName) {
101-
Span span = createTableSpan(getClass().getSimpleName() + "." + methodName, tableName);
101+
Span span = createTableSpan("AsyncRegionLocator." + methodName, tableName);
102102
try (Scope scope = span.makeCurrent()) {
103103
CompletableFuture<T> future = action.get();
104104
FutureUtils.addListener(future, (resp, error) -> {

hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,6 +305,6 @@ public static CompletableFuture<AsyncConnection> createAsyncConnection(Configura
305305
}
306306
});
307307
return future;
308-
}, ConnectionFactory.class.getSimpleName() + ".createAsyncConnection");
308+
}, "ConnectionFactory.createAsyncConnection");
309309
}
310310
}

0 commit comments

Comments
 (0)