HBASE-28604 Fix the error message in ReservoirSample's constructor (#5920)

Signed-off-by: Nick Dimiduk <[email protected]>
(cherry picked from commit 6b7aaed)

Author: Apache9

hbase-common/src/main/java/org/apache/hadoop/hbase/util/ReservoirSample.java

@@ -41,7 +41,7 @@ public class ReservoirSample<T> {
   private int n;
 
   public ReservoirSample(int k) {
-    Preconditions.checkArgument(k > 0, "negative sampling number(%d) is not allowed");
+    Preconditions.checkArgument(k > 0, "negative sampling number(%s) is not allowed", k);
     r = new ArrayList<>(k);
     this.k = k;
   }

hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestReservoirSample.java

@@ -18,6 +18,7 @@
 package org.apache.hadoop.hbase.util;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertThrows;
 import static org.junit.Assert.assertTrue;
 
 import java.util.stream.IntStream;
@@ -89,4 +90,11 @@ public void testStream() {
     assertTrue(containsOne > round / 10 * 0.95);
     assertTrue(containsOne < round / 10 * 1.05);
   }
+
+  @Test
+  public void testNegativeSamplingNumber() {
+    IllegalArgumentException e =
+      assertThrows(IllegalArgumentException.class, () -> new ReservoirSample<Integer>(-1));
+    assertEquals("negative sampling number(-1) is not allowed", e.getMessage());
+  }
 }