HBASE-26185 Return mutable list in AssignmentManager#getExcludedServersForSystemTable (#3577)

shahrs87 · virajjasani · commit 9d34fa7d5824 · 2021-08-12T13:48:17.000+05:30
Signed-off-by: Viraj Jasani &lt;vjasani@apache.org&gt;
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
@@ -2309,15 +2309,15 @@ public List<ServerName> getExcludedServersForSystemTable() {
       .map(s->new Pair<>(s, master.getRegionServerVersion(s)))
       .collect(Collectors.toList());
     if (serverList.isEmpty()) {
-      return Collections.emptyList();
+      return new ArrayList<>();
     }
     String highestVersion = Collections.max(serverList,
       (o1, o2) -> VersionInfo.compareVersion(o1.getSecond(), o2.getSecond())).getSecond();
     if (!DEFAULT_MIN_VERSION_MOVE_SYS_TABLES_CONFIG.equals(minVersionToMoveSysTables)) {
       int comparedValue = VersionInfo.compareVersion(minVersionToMoveSysTables,
         highestVersion);
       if (comparedValue > 0) {
-        return Collections.emptyList();
+        return new ArrayList<>();
       }
     }
     return serverList.stream()

Original file line number	Diff line number	Diff line change
`@@ -2309,15 +2309,15 @@ public List<ServerName> getExcludedServersForSystemTable() {`
`2309`	`2309`	`.map(s->new Pair<>(s, master.getRegionServerVersion(s)))`
`2310`	`2310`	`.collect(Collectors.toList());`
`2311`	`2311`	`if (serverList.isEmpty()) {`
`2312`		`- return Collections.emptyList();`
	`2312`	`+ return new ArrayList<>();`
`2313`	`2313`	`}`
`2314`	`2314`	`String highestVersion = Collections.max(serverList,`
`2315`	`2315`	`(o1, o2) -> VersionInfo.compareVersion(o1.getSecond(), o2.getSecond())).getSecond();`
`2316`	`2316`	`if (!DEFAULT_MIN_VERSION_MOVE_SYS_TABLES_CONFIG.equals(minVersionToMoveSysTables)) {`
`2317`	`2317`	`int comparedValue = VersionInfo.compareVersion(minVersionToMoveSysTables,`
`2318`	`2318`	`highestVersion);`
`2319`	`2319`	`if (comparedValue > 0) {`
`2320`		`- return Collections.emptyList();`
	`2320`	`+ return new ArrayList<>();`
`2321`	`2321`	`}`
`2322`	`2322`	`}`
`2323`	`2323`	`return serverList.stream()`