Skip to content

Commit 9a2b5e0

Browse files
committed
review feedback
1 parent 6b2d23e commit 9a2b5e0

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/LoadCandidateGenerator.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@ private int pickLeastLoadedServer(final BalancerClusterState cluster, int thisSe
4747
break;
4848
}
4949
// we don't know how many servers have the same region count, we will randomly select one
50-
// using reservoir sampling (http://gregable.com/2007/10/reservoir-sampling.html)
50+
// using a simplified inline reservoir sampling by assignmening a random number to stream
51+
// data and choose the greatest one. (http://gregable.com/2007/10/reservoir-sampling.html)
5152
double currentRandom = ThreadLocalRandom.current().nextDouble();
5253
if (currentRandom > currentLargestRandom) {
5354
selectedIndex = i;
@@ -72,7 +73,8 @@ private int pickMostLoadedServer(final BalancerClusterState cluster, int thisSer
7273
break;
7374
}
7475
// we don't know how many servers have the same region count, we will randomly select one
75-
// using reservoir sampling (http://gregable.com/2007/10/reservoir-sampling.html)
76+
// using a simplified inline reservoir sampling by assignmening a random number to stream
77+
// data and choose the greatest one. (http://gregable.com/2007/10/reservoir-sampling.html)
7678
double currentRandom = ThreadLocalRandom.current().nextDouble();
7779
if (currentRandom > currentLargestRandom) {
7880
selectedIndex = i;

0 commit comments

Comments
 (0)