HBASE-22709 Add a chore thread in master to do hbck checking (#404)

Signed-off-by: stack <[email protected]>

Author: infraio

hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/AssignmentManagerStatusTmpl.jamon

@@ -42,84 +42,8 @@ int limit = 100;
 <%java>
 SortedSet<RegionState> rit = assignmentManager.getRegionStates()
     .getRegionsInTransitionOrderedByTimestamp();
-Map<String, Pair<ServerName, Set<ServerName>>> problematicRegions = assignmentManager
-    .getProblematicRegions();
 </%java>
 
-<%if !problematicRegions.isEmpty() %>
-<%java>
-int totalSize = problematicRegions.size();
-int sizePerPage = Math.min(10, totalSize);
-int numOfPages = (int) Math.ceil(totalSize * 1.0 / sizePerPage);
-</%java>
-    <section>
-    <h2><a name="problem-regions">Problematic Regions</a></h2>
-    <p>
-        <span>
-            <% problematicRegions.size() %> problematic region(s). There are three case: 1. Master
-             thought this region opened, but no regionserver reported it. 2. Master thought this
-              region opened on Server1, but regionserver reported Server2. 3. More than one
-               regionservers reported opened this region. Notice: the reported online regionservers
-                may be not right when there are regions in transition. Please check them in
-                 regionserver's web UI.
-        </span>
-    </p>
-    <div class="tabbable">
-        <div class="tab-content">
-        <%java int recordItr = 0; %>
-        <%for Map.Entry<String, Pair<ServerName, Set<ServerName>>> entry : problematicRegions.entrySet() %>
-            <%if (recordItr % sizePerPage) == 0 %>
-                <%if recordItr == 0 %>
-                    <div class="tab-pane active" id="tab_prs<% (recordItr / sizePerPage) + 1 %>">
-                <%else>
-                    <div class="tab-pane" id="tab_prs<% (recordItr / sizePerPage) + 1 %>">
-                </%if>
-                <table class="table table-striped" style="margin-bottom:0px;">
-                    <tr>
-                        <th>Region</th>
-                        <th>Location in META</th>
-                        <th>Reported Online Region Servers</th>
-                    </tr>
-            </%if>
-
-            <tr>
-                <td><% entry.getKey() %></td>
-                <td><% entry.getValue().getFirst() %></td>
-                <td><% entry.getValue().getSecond().stream().map(ServerName::getServerName)
-                    .collect(Collectors.joining(", ")) %></td>
-            </tr>
-            <%java recordItr++; %>
-            <%if (recordItr % sizePerPage) == 0 %>
-                </table>
-                </div>
-            </%if>
-        </%for>
-
-        <%if (recordItr % sizePerPage) != 0 %>
-         <%for ; (recordItr % sizePerPage) != 0 ; recordItr++ %>
-            <tr><td colspan="3" style="height:61px"></td></tr>
-         </%for>
-         </table>
-         </div>
-        </%if>
-
-        </div>
-        <nav>
-         <ul class="nav nav-pills pagination">
-         <%for int i = 1 ; i <= numOfPages; i++ %>
-             <%if i == 1 %>
-             <li class="active">
-             <%else>
-             <li>
-             </%if>
-             <a href="#tab_prs<% i %>"><% i %></a></li>
-         </%for>
-         </ul>
-        </nav>
-    </div>
-    </section>
-</%if>
-
 <%if !rit.isEmpty() %>
 <%java>
 long currentTime = System.currentTimeMillis();

hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon

@@ -145,7 +145,8 @@ AssignmentManager assignmentManager = master.getAssignmentManager();
                 <li class="active"><a href="/">Home</a></li>
                 <li><a href="/tablesDetailed.jsp">Table Details</a></li>
                 <%if master.isActiveMaster() %>
-                <li><a href="/procedures.jsp">Procedures &amp; Locks</a></li>
+                    <li><a href="/procedures.jsp">Procedures &amp; Locks</a></li>
+                    <li><a href="/hbck.jsp">HBCK Report</a></li>
                 </%if>
                 <li><a href="/processMaster.jsp">Process Metrics</a></li>
                 <li><a href="/logs/">Local Logs</a></li>

hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java

@@ -354,6 +354,7 @@ public void run() {
   private ClusterStatusChore clusterStatusChore;
   private ClusterStatusPublisher clusterStatusPublisherChore = null;
 
+  private HbckChecker hbckChecker;
   CatalogJanitor catalogJanitorChore;
 
   private ReplicationZKNodeCleanerChore replicationZKNodeCleanerChore;
@@ -991,6 +992,8 @@ private void finishActiveMasterInitialization(MonitoredTask status)
     getChoreService().scheduleChore(normalizerChore);
     this.catalogJanitorChore = new CatalogJanitor(this);
     getChoreService().scheduleChore(catalogJanitorChore);
+    this.hbckChecker = new HbckChecker(this);
+    getChoreService().scheduleChore(hbckChecker);
 
     // NAMESPACE READ!!!!
     // Here we expect hbase:namespace to be online. See inside initClusterSchemaService.
@@ -1456,13 +1459,15 @@ private void stopChores() {
     if (this.mobCompactThread != null) {
       this.mobCompactThread.close();
     }
-
     if (this.quotaObserverChore != null) {
       quotaObserverChore.cancel();
     }
     if (this.snapshotQuotaChore != null) {
       snapshotQuotaChore.cancel();
     }
+    if (this.hbckChecker != null) {
+      hbckChecker.cancel();
+    }
   }
 
   /**
@@ -3784,4 +3789,8 @@ public static void decorateMasterConfiguration(Configuration conf) {
       }
     }
   }
+
+  public HbckChecker getHbckChecker() {
+    return this.hbckChecker;
+  }
 }