HBASE-27494: Fix missing meta cache dropping exception metrics (#4902)

briaugenreich · bbeaudreault · commit 8b5fe81c0395 · 2022-11-30T13:05:49.000-05:00
Signed-off-by: Bryan Beaudreault &lt;bbeaudreault@apache.org&gt;
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java
@@ -912,6 +912,10 @@ private void cleanServerCache(ServerName server, Throwable regionException) {
     if (ClientExceptionsUtil.isMetaClearingException(regionException)) {
       // We want to make sure to clear the cache in case there were location-related exceptions.
       // We don't to clear the cache for every possible exception that comes through, however.
+      MetricsConnection metrics = asyncProcess.connection.getConnectionMetrics();
+      if (metrics != null) {
+        metrics.incrCacheDroppingExceptions(regionException);
+      }
       asyncProcess.connection.clearCaches(server);
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -912,6 +912,10 @@ private void cleanServerCache(ServerName server, Throwable regionException) {`
`912`	`912`	`if (ClientExceptionsUtil.isMetaClearingException(regionException)) {`
`913`	`913`	`// We want to make sure to clear the cache in case there were location-related exceptions.`
`914`	`914`	`// We don't to clear the cache for every possible exception that comes through, however.`
	`915`	`+ MetricsConnection metrics = asyncProcess.connection.getConnectionMetrics();`
	`916`	`+ if (metrics != null) {`
	`917`	`+ metrics.incrCacheDroppingExceptions(regionException);`
	`918`	`+ }`
`915`	`919`	`asyncProcess.connection.clearCaches(server);`
`916`	`920`	`}`
`917`	`921`	`}`