HBASE-27494: Fix missing meta cache dropping exception metrics (#4902)

briaugenreich · bbeaudreault · commit 751b6b9b6829 · 2022-11-30T13:06:16.000-05:00
Signed-off-by: Bryan Beaudreault &lt;bbeaudreault@apache.org&gt;
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java
@@ -908,6 +908,10 @@ private void cleanServerCache(ServerName server, Throwable regionException) {
     if (ClientExceptionsUtil.isMetaClearingException(regionException)) {
       // We want to make sure to clear the cache in case there were location-related exceptions.
       // We don't to clear the cache for every possible exception that comes through, however.
+      MetricsConnection metrics = asyncProcess.connection.getConnectionMetrics();
+      if (metrics != null) {
+        metrics.incrCacheDroppingExceptions(regionException);
+      }
       asyncProcess.connection.clearCaches(server);
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -908,6 +908,10 @@ private void cleanServerCache(ServerName server, Throwable regionException) {`
`908`	`908`	`if (ClientExceptionsUtil.isMetaClearingException(regionException)) {`
`909`	`909`	`// We want to make sure to clear the cache in case there were location-related exceptions.`
`910`	`910`	`// We don't to clear the cache for every possible exception that comes through, however.`
	`911`	`+ MetricsConnection metrics = asyncProcess.connection.getConnectionMetrics();`
	`912`	`+ if (metrics != null) {`
	`913`	`+ metrics.incrCacheDroppingExceptions(regionException);`
	`914`	`+ }`
`911`	`915`	`asyncProcess.connection.clearCaches(server);`
`912`	`916`	`}`
`913`	`917`	`}`