addressing javadoc, checkstyle and spotless issues

Change-Id: I49d287cddf81170514474b27a642c249a7bc79d7

Author: wchevreuil

hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java

@@ -213,9 +213,9 @@ default Optional<Boolean> shouldCacheFile(HFileInfo hFileInfo, Configuration con
    * not be overridden by all implementing classes. In such cases, the returned Optional will be
    * empty. For subclasses implementing this logic, the returned Optional would contain the boolean
    * value reflecting if the passed block should indeed be cached.
-   * @param key              The key representing the block to check if it should be cached.
-   * @param timeRangeTracker the time range tracker containing the timestamps
-   * @param conf             The configuration object to use for determining caching behavior.
+   * @param key          The key representing the block to check if it should be cached.
+   * @param maxTimeStamp The maximum timestamp for the block to check if it should be cached.
+   * @param conf         The configuration object to use for determining caching behavior.
    * @return An empty Optional if this method is not supported; otherwise, the returned Optional
    *         contains the boolean value indicating if the block should be cached.
    */

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CustomCellTieredUtils.java

@@ -28,6 +28,9 @@
 
 @InterfaceAudience.Private
 public class CustomCellTieredUtils {
+  private CustomCellTieredUtils() {
+    // Utility class, no instantiation
+  }
 
   public static void checkForModifyTable(TableDescriptor newTable) throws IOException {
     for (ColumnFamilyDescriptor descriptor : newTable.getColumnFamilies()) {

hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCustomCellDataTieringManager.java

@@ -19,7 +19,6 @@
 
 import static org.apache.hadoop.hbase.HConstants.BUCKET_CACHE_SIZE_KEY;
 import static org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.DEFAULT_ERROR_TOLERATION_DURATION;
-import static org.apache.hadoop.hbase.regionserver.TestDataTieringManager.createHStoreFile;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertNotNull;
@@ -81,12 +80,14 @@
  * This class is used to test the functionality of the DataTieringManager.
  *
  * The mock online regions are stored in {@link TestCustomCellDataTieringManager#testOnlineRegions}.
- * For all tests, the setup of {@link TestCustomCellDataTieringManager#testOnlineRegions} occurs only once.
+ * For all tests, the setup of
+ *  {@link TestCustomCellDataTieringManager#testOnlineRegions} occurs only once.
  * Please refer to {@link TestCustomCellDataTieringManager#setupOnlineRegions()} for the structure.
- * Additionally, a list of all store files is maintained in {@link TestCustomCellDataTieringManager#hStoreFiles}.
+ * Additionally, a list of all store files is
+ *  maintained in {@link TestCustomCellDataTieringManager#hStoreFiles}.
  * The characteristics of these store files are listed below:
- * @formatter:off ## HStoreFile Information
- *
+ * @formatter:off
+ * ## HStoreFile Information
  * | HStoreFile       | Region             | Store               | DataTiering           | isHot |
  * |------------------|--------------------|---------------------|-----------------------|-------|
  * | hStoreFile0      | region1            | hStore11            | CUSTOM_CELL_VALUE     | true  |