Skip to content

Commit 72be041

Browse files
authored
HBASE-24686 [LOG] Log improvement in Connection#close (#2219)
Signed-off-by: Pankaj Kumar <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Sean Busbey <[email protected]>
1 parent 54fe81e commit 72be041

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -201,6 +201,10 @@ public void close() {
201201
if (!closed.compareAndSet(false, true)) {
202202
return;
203203
}
204+
LOG.info("Connection has been closed by {}.", Thread.currentThread().getName());
205+
if(LOG.isDebugEnabled()){
206+
logCallStack(Thread.currentThread().getStackTrace());
207+
}
204208
IOUtils.closeQuietly(clusterStatusListener);
205209
IOUtils.closeQuietly(rpcClient);
206210
IOUtils.closeQuietly(registry);
@@ -214,6 +218,16 @@ public void close() {
214218
}
215219
}
216220

221+
private void logCallStack(StackTraceElement[] stackTraceElements) {
222+
StringBuilder stackBuilder = new StringBuilder("Call stack:");
223+
for (StackTraceElement element : stackTraceElements) {
224+
stackBuilder.append("\n at ");
225+
stackBuilder.append(element);
226+
}
227+
stackBuilder.append("\n");
228+
LOG.debug(stackBuilder.toString());
229+
}
230+
217231
@Override
218232
public AsyncTableRegionLocator getRegionLocator(TableName tableName) {
219233
return new AsyncTableRegionLocatorImpl(tableName, this);

0 commit comments

Comments
 (0)