HBASE-29223 Extended TestMasterStatusPage with more tests

Author: PDavid

hbase-server/src/test/java/org/apache/hadoop/hbase/master/http/TestMasterStatusPage.java

@@ -17,28 +17,30 @@
  */
 package org.apache.hadoop.hbase.master.http;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.*;
 
 import java.io.BufferedReader;
 import java.io.IOException;
 import java.io.InputStreamReader;
 import java.net.HttpURLConnection;
 import java.net.URL;
+import java.util.ArrayList;
+import java.util.List;
 import org.apache.hadoop.conf.Configuration;
 import org.apache.hadoop.fs.Path;
-import org.apache.hadoop.hbase.HBaseClassTestRule;
-import org.apache.hadoop.hbase.HBaseTestingUtil;
-import org.apache.hadoop.hbase.HConstants;
-import org.apache.hadoop.hbase.LocalHBaseCluster;
+import org.apache.hadoop.hbase.*;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptor;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
+import org.apache.hadoop.hbase.master.HMaster;
+import org.apache.hadoop.hbase.master.ServerManager;
 import org.apache.hadoop.hbase.testclassification.MasterTests;
 import org.apache.hadoop.hbase.testclassification.MediumTests;
 import org.apache.hadoop.hbase.util.CommonFSUtils;
-import org.junit.AfterClass;
-import org.junit.BeforeClass;
-import org.junit.ClassRule;
-import org.junit.Rule;
-import org.junit.Test;
+import org.apache.hadoop.hbase.util.MasterStatusUtil;
+import org.apache.hadoop.hbase.util.VersionInfo;
+import org.junit.*;
 import org.junit.experimental.categories.Category;
 import org.junit.rules.TestName;
 
@@ -50,6 +52,8 @@ public class TestMasterStatusPage {
     HBaseClassTestRule.forClass(TestMasterStatusPage.class);
 
   private final static HBaseTestingUtil UTIL = new HBaseTestingUtil();
+  public static final String TEST_TABLE_NAME_1 = "TEST_TABLE_1";
+  public static final String TEST_TABLE_NAME_2 = "TEST_TABLE_2";
 
   private static LocalHBaseCluster CLUSTER;
 
@@ -90,23 +94,49 @@ public static void shutDownMiniCluster() throws Exception {
 
   @Test
   public void testMasterStatusPage() throws Exception {
+    HMaster master = CLUSTER.getActiveMaster();
+
+    createTestTables(master);
+
+    String page = getMasterStatusPageContent();
+
+    String hostname = master.getServerName().getHostname();
+    assertTrue(page.contains("<h1>Master <small>" + hostname + "</small></h1>"));
+    assertTrue(page.contains("<h2><a name=\"regionservers\">Region Servers</a></h2>"));
+    assertRegionServerLinks(master, page);
+
+    assertTrue(page.contains("<h2>Backup Masters</h2>"));
+    assertTrue(page.contains("<h2><a name=\"tables\">Tables</a></h2>"));
+    assertTableLinks(master, page);
+
+    assertTrue(page.contains("<h2><a name=\"region_visualizer\"></a>Region Visualizer</h2>"));
+    assertTrue(page.contains("<h2><a name=\"peers\">Peers</a></h2>"));
+    assertTrue(page.contains("<h2><a name=\"tasks\">Tasks</a></h2>"));
+    assertTrue(page.contains("<h2><a name=\"attributes\">Software Attributes</a></h2>"));
+
+    assertTrue(page.contains(VersionInfo.getVersion()));
+  }
+
+  private String getMasterStatusPageContent() throws IOException {
     URL url = new URL(getInfoServerHostAndPort() + "/master-status");
     HttpURLConnection conn = (HttpURLConnection) url.openConnection();
     conn.connect();
 
     assertEquals(200, conn.getResponseCode());
     assertEquals("text/html;charset=utf-8", conn.getContentType());
 
-    String responseBody = getResponseBody(conn);
-    assertTrue(responseBody.contains("<h1>Master"));
-    assertTrue(responseBody.contains("<h2><a name=\"regionservers\">Region Servers</a></h2>"));
-    assertTrue(responseBody.contains("<h2>Backup Masters</h2>"));
-    assertTrue(responseBody.contains("<h2><a name=\"tables\">Tables</a></h2>"));
-    assertTrue(
-      responseBody.contains("<h2><a name=\"region_visualizer\"></a>Region Visualizer</h2>"));
-    assertTrue(responseBody.contains("<h2><a name=\"peers\">Peers</a></h2>"));
-    assertTrue(responseBody.contains("<h2><a name=\"tasks\">Tasks</a></h2>"));
-    assertTrue(responseBody.contains("<h2><a name=\"attributes\">Software Attributes</a></h2>"));
+    return getResponseBody(conn);
+  }
+
+  private static void createTestTables(HMaster master) throws IOException {
+    ColumnFamilyDescriptor cf = ColumnFamilyDescriptorBuilder.of("CF");
+    TableDescriptor tableDescriptor1 = TableDescriptorBuilder
+      .newBuilder(TableName.valueOf(TEST_TABLE_NAME_1)).setColumnFamily(cf).build();
+    master.createTable(tableDescriptor1, null, 0, 0);
+    TableDescriptor tableDescriptor2 = TableDescriptorBuilder
+      .newBuilder(TableName.valueOf(TEST_TABLE_NAME_2)).setColumnFamily(cf).build();
+    master.createTable(tableDescriptor2, null, 0, 0);
+    master.flushMasterStore();
   }
 
   private String getInfoServerHostAndPort() {
@@ -122,4 +152,26 @@ private static String getResponseBody(HttpURLConnection conn) throws IOException
     }
     return sb.toString();
   }
+
+  private static void assertRegionServerLinks(HMaster master, String responseBody) {
+    ServerManager serverManager = master.getServerManager();
+    List<ServerName> servers = serverManager.getOnlineServersList();
+    assertEquals(1, servers.size());
+    for (ServerName serverName : servers) {
+      String expectedRsLink = MasterStatusUtil.serverNameLink(master, serverName);
+      assertTrue(responseBody.contains(expectedRsLink));
+    }
+  }
+
+  private static void assertTableLinks(HMaster master, String responseBody) {
+    List<TableDescriptor> tables = new ArrayList<>();
+    String errorMessage = MasterStatusUtil.getUserTables(master, tables);
+    assertNull(errorMessage);
+    assertEquals(2, tables.size());
+    for (TableDescriptor table : tables) {
+      String tableName = table.getTableName().getNameAsString();
+      String expectedTableLink = "<a href=table.jsp?name=" + tableName + ">" + tableName + "</a>";
+      assertTrue(responseBody.contains(expectedTableLink));
+    }
+  }
 }