Skip to content

Commit 24a345a

Browse files
committed
HBASE-27951 Use ADMIN_QOS in MasterRpcServices for regionserver operational dependencies (#5309)
It seems not correct to have the MasterRpcServices methods for direct regionserver<->master communication (regionServerStartup, regionServerReport, and reportFatalRSError) contending with normal priority requests. They should be made ADMIN_QOS priority to avoid potential operational deadlocks. Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> Reviewed-by: Aman Poonia <[email protected]>
1 parent 60580b8 commit 24a345a

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -535,6 +535,7 @@ public GetLastFlushedSequenceIdResponse getLastFlushedSequenceId(RpcController c
535535
}
536536

537537
@Override
538+
@QosPriority(priority = HConstants.ADMIN_QOS)
538539
public RegionServerReportResponse regionServerReport(RpcController controller,
539540
RegionServerReportRequest request) throws ServiceException {
540541
try {
@@ -566,6 +567,7 @@ public RegionServerReportResponse regionServerReport(RpcController controller,
566567
}
567568

568569
@Override
570+
@QosPriority(priority = HConstants.ADMIN_QOS)
569571
public RegionServerStartupResponse regionServerStartup(RpcController controller,
570572
RegionServerStartupRequest request) throws ServiceException {
571573
// Register with server manager
@@ -597,6 +599,7 @@ public RegionServerStartupResponse regionServerStartup(RpcController controller,
597599
}
598600

599601
@Override
602+
@QosPriority(priority = HConstants.ADMIN_QOS)
600603
public ReportRSFatalErrorResponse reportRSFatalError(RpcController controller,
601604
ReportRSFatalErrorRequest request) throws ServiceException {
602605
String errorText = request.getErrorMessage();

0 commit comments

Comments
 (0)