HBASE-27712 Remove unused params in region metrics

Author: thangTang

hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java

@@ -73,15 +73,14 @@ public interface MetricsRegionSource extends Comparable<MetricsRegionSource> {
   void updateDelete();
 
   /**
-   * Update time of gets
-   * @param mills time for this get operation.
+   * Update related counts of gets
    */
-  void updateGet(long mills);
+  void updateGet();
 
   /**
-   * Update time used of resultScanner.next().
+   * Update related counts of resultScanner.next().
    */
-  void updateScanTime(long mills);
+  void updateScanCount();
 
   /**
    * Update related counts of increments.

hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java

@@ -149,12 +149,12 @@ public void updateDelete() {
   }
 
   @Override
-  public void updateGet(long mills) {
+  public void updateGet() {
     regionGet.incr();
   }
 
   @Override
-  public void updateScanTime(long mills) {
+  public void updateScanCount() {
     regionScan.incr();
   }
 

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java

@@ -7875,12 +7875,11 @@ private List<Cell> get(Get get, boolean withCoprocessor, long nonceGroup, long n
   private List<Cell> getInternal(Get get, boolean withCoprocessor, long nonceGroup, long nonce)
     throws IOException {
     List<Cell> results = new ArrayList<>();
-    long before = EnvironmentEdgeManager.currentTime();
 
     // pre-get CP hook
     if (withCoprocessor && (coprocessorHost != null)) {
       if (coprocessorHost.preGet(get, results)) {
-        metricsUpdateForGet(results, before);
+        metricsUpdateForGet();
         return results;
       }
     }
@@ -7904,14 +7903,14 @@ private List<Cell> getInternal(Get get, boolean withCoprocessor, long nonceGroup
       coprocessorHost.postGet(get, results);
     }
 
-    metricsUpdateForGet(results, before);
+    metricsUpdateForGet();
 
     return results;
   }
 
-  void metricsUpdateForGet(List<Cell> results, long before) {
+  void metricsUpdateForGet() {
     if (this.metricsRegion != null) {
-      this.metricsRegion.updateGet(EnvironmentEdgeManager.currentTime() - before);
+      this.metricsRegion.updateGet();
     }
     if (this.rsServices != null && this.rsServices.getMetrics() != null) {
       rsServices.getMetrics().updateReadQueryMeter(this, 1);

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegion.java

@@ -50,12 +50,12 @@ public void updateDelete() {
     source.updateDelete();
   }
 
-  public void updateGet(final long t) {
-    source.updateGet(t);
+  public void updateGet() {
+    source.updateGet();
   }
 
-  public void updateScanTime(final long t) {
-    source.updateScanTime(t);
+  public void updateScanCount() {
+    source.updateScanCount();
   }
 
   public void updateFilteredRecords() {

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java

@@ -2514,11 +2514,10 @@ private Result get(Get get, HRegion region, RegionScannersCloseCallBack closeCal
 
     // This method is almost the same as HRegion#get.
     List<Cell> results = new ArrayList<>();
-    long before = EnvironmentEdgeManager.currentTime();
     // pre-get CP hook
     if (region.getCoprocessorHost() != null) {
       if (region.getCoprocessorHost().preGet(get, results)) {
-        region.metricsUpdateForGet(results, before);
+        region.metricsUpdateForGet();
         return Result.create(results, get.isCheckExistenceOnly() ? !results.isEmpty() : null,
           stale);
       }
@@ -2553,7 +2552,7 @@ private Result get(Get get, HRegion region, RegionScannersCloseCallBack closeCal
     if (region.getCoprocessorHost() != null) {
       region.getCoprocessorHost().postGet(get, results);
     }
-    region.metricsUpdateForGet(results, before);
+    region.metricsUpdateForGet();
 
     return Result.create(results, get.isCheckExistenceOnly() ? !results.isEmpty() : null, stale);
   }
@@ -3449,7 +3448,7 @@ private void scan(HBaseRpcController controller, ScanRequest request, RegionScan
       // Update serverside metrics, even on error.
       long end = EnvironmentEdgeManager.currentTime();
       long responseCellSize = rpcCall != null ? rpcCall.getResponseCellSize() : 0;
-      region.getMetrics().updateScanTime(end - before);
+      region.getMetrics().updateScanCount();
       final MetricsRegionServer metricsRegionServer = server.getMetrics();
       if (metricsRegionServer != null) {
         metricsRegionServer.updateScanSize(region, responseCellSize);