From 730103e6f66d7bd9b9f39024dd8468969f280bd4 Mon Sep 17 00:00:00 2001
From: zhtttylz <hualong.z@hotmail.com>
Date: Tue, 1 Oct 2024 23:03:00 +0800
Subject: [PATCH 1/2] HDFS-17461. Fix spotbugs in ServiceScheduler#load

---
 .../hadoop-yarn-services/dev-support/findbugs-exclude.xml    | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/dev-support/findbugs-exclude.xml b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/dev-support/findbugs-exclude.xml
index 15ce952ef3c7a..d7d79a3d16b3e 100644
--- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/dev-support/findbugs-exclude.xml
+++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/dev-support/findbugs-exclude.xml
@@ -56,4 +56,9 @@
       </Or>
       <Bug pattern="SE_BAD_FIELD" />
   </Match>
+  <Match>
+      <Class name="org.apache.hadoop.yarn.service.ServiceScheduler$1"/>
+      <Method name="load"/>
+      <Bug code="NP" pattern="NP_NONNULL_RETURN_VIOLATION"/>
+  </Match>
 </FindBugsFilter>

From aa5e405df7246d701defbc4ea5d7011e65f1c529 Mon Sep 17 00:00:00 2001
From: zhtttylz <hualong.z@hotmail.com>
Date: Wed, 2 Oct 2024 09:46:30 +0800
Subject: [PATCH 2/2] fix checkstyle.

---
 .../hadoop-yarn/dev-support/findbugs-exclude.xml          | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml b/hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml
index bad2bacb1a57b..b98ac0bd921b2 100644
--- a/hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml
+++ b/hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml
@@ -726,12 +726,4 @@
     <Package name="org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.placement.schema" />
   </Match>
 
-  <!-- The ServiceScheduler#createConfigFileCache method uses the `load` method,
-       which is not allowed to return null; we can ignore it here. -->
-  <Match>
-    <Class name="org.apache.hadoop.yarn.service.ServiceScheduler"/>
-    <Method name="$1.load(ConfigFile)" />
-    <Bug pattern="NP_NONNULL_RETURN_VIOLATION"/>
-  </Match>
-
 </FindBugsFilter>