From a5798bf2a05c05baead0e7b25b67412531a19ded Mon Sep 17 00:00:00 2001 From: slfan1989 Date: Mon, 13 Nov 2023 22:41:12 +0800 Subject: [PATCH 1/4] YARN-11614. [Federation] Add Federation PolicyManager Validation Rules. --- .../FederationQueueWeight.java | 20 +++++++++++++++++++ .../hadoop/yarn/client/cli/RouterCLI.java | 9 ++++++++- 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/FederationQueueWeight.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/FederationQueueWeight.java index aa9d114527410..d1b8bcbad04de 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/FederationQueueWeight.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/FederationQueueWeight.java @@ -170,6 +170,26 @@ public static void checkHeadRoomAlphaValid(String headRoomAlpha) throws YarnExce } } + public static void checkPolicyManagerValid(String policyManager) throws YarnException { + switch (policyManager) { + case "org.apache.hadoop.yarn.server.federation.policies.manager.HashBroadcastPolicyManager": + throw new YarnException("HashBroadcastPolicyManager does not support the use of queue weights."); + case "org.apache.hadoop.yarn.server.federation.policies.manager.HomePolicyManager": + throw new YarnException("HomePolicyManager does not support the use of queue weights."); + case "org.apache.hadoop.yarn.server.federation.policies.manager.RejectAllPolicyManager": + throw new YarnException("RejectAllPolicyManager does not support the " + + "use of queue weights."); + case "org.apache.hadoop.yarn.server.federation.policies.manager.UniformBroadcastPolicyManager": + throw new YarnException("UniformBroadcastPolicyManager does not support the " + + "use of queue weights."); + case "org.apache.hadoop.yarn.server.federation.policies.manager.WeightedLocalityPolicyManager": + case "org.apache.hadoop.yarn.server.federation.policies.manager.PriorityBroadcastPolicyManager": + break; + default: + throw new YarnException("Unknown PolicyManager"); + } + } + /** * Determines whether the given value is a number. * diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RouterCLI.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RouterCLI.java index 2da584f9d61bb..c8f7efe5d8ea1 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RouterCLI.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RouterCLI.java @@ -75,6 +75,7 @@ import static org.apache.hadoop.yarn.server.api.protocolrecords.FederationQueueWeight.checkHeadRoomAlphaValid; import static org.apache.hadoop.yarn.server.api.protocolrecords.FederationQueueWeight.checkSubClusterQueueWeightRatioValid; +import static org.apache.hadoop.yarn.server.api.protocolrecords.FederationQueueWeight.checkPolicyManagerValid; public class RouterCLI extends Configured implements Tool { @@ -634,6 +635,8 @@ protected SaveFederationQueuePolicyRequest parsePolicy(String policy) throws Yar FederationQueueWeight.newInstance(routerWeight, amrmWeight, headroomalpha); String policyManager = getConf().get(YarnConfiguration.FEDERATION_POLICY_MANAGER, YarnConfiguration.DEFAULT_FEDERATION_POLICY_MANAGER); + checkPolicyManagerValid(policyManager); + SaveFederationQueuePolicyRequest request = SaveFederationQueuePolicyRequest.newInstance( queue, federationQueueWeight, policyManager); @@ -654,6 +657,11 @@ protected SaveFederationQueuePolicyRequest parsePolicy(String policy) throws Yar */ protected int parseXml2PoliciesAndBatchSavePolicies(String policiesXml) { try { + + String policyManager = getConf().get(YarnConfiguration.FEDERATION_POLICY_MANAGER, + YarnConfiguration.DEFAULT_FEDERATION_POLICY_MANAGER); + checkPolicyManagerValid(policyManager); + List federationQueueWeightsList = parsePoliciesByXml(policiesXml); MemoryPageUtils memoryPageUtils = new MemoryPageUtils<>(20); federationQueueWeightsList.forEach(federationQueueWeight -> @@ -726,7 +734,6 @@ protected List parsePoliciesByXml(String policiesXml) String policyManager = getConf().get(YarnConfiguration.FEDERATION_POLICY_MANAGER, YarnConfiguration.DEFAULT_FEDERATION_POLICY_MANAGER); - LOG.debug("Queue: {}, AmrmPolicyWeights: {}, RouterWeight: {}, HeadroomAlpha: {}.", queueName, amrmWeight, routerWeight, headroomAlpha); From 1d6c0703a68d0fe703497bbcc6cebde1f2abd804 Mon Sep 17 00:00:00 2001 From: slfan1989 Date: Thu, 16 Nov 2023 23:15:29 +0800 Subject: [PATCH 2/4] YARN-11614. Fix CheckStyle. --- .../FederationQueueWeight.java | 20 --------------- .../hadoop/yarn/client/cli/RouterCLI.java | 9 +------ .../yarn/server/router/RouterServerUtil.java | 8 ++++++ .../rmadmin/FederationRMAdminInterceptor.java | 25 ++++++++++++++++--- 4 files changed, 31 insertions(+), 31 deletions(-) diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/FederationQueueWeight.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/FederationQueueWeight.java index d1b8bcbad04de..aa9d114527410 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/FederationQueueWeight.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/FederationQueueWeight.java @@ -170,26 +170,6 @@ public static void checkHeadRoomAlphaValid(String headRoomAlpha) throws YarnExce } } - public static void checkPolicyManagerValid(String policyManager) throws YarnException { - switch (policyManager) { - case "org.apache.hadoop.yarn.server.federation.policies.manager.HashBroadcastPolicyManager": - throw new YarnException("HashBroadcastPolicyManager does not support the use of queue weights."); - case "org.apache.hadoop.yarn.server.federation.policies.manager.HomePolicyManager": - throw new YarnException("HomePolicyManager does not support the use of queue weights."); - case "org.apache.hadoop.yarn.server.federation.policies.manager.RejectAllPolicyManager": - throw new YarnException("RejectAllPolicyManager does not support the " + - "use of queue weights."); - case "org.apache.hadoop.yarn.server.federation.policies.manager.UniformBroadcastPolicyManager": - throw new YarnException("UniformBroadcastPolicyManager does not support the " + - "use of queue weights."); - case "org.apache.hadoop.yarn.server.federation.policies.manager.WeightedLocalityPolicyManager": - case "org.apache.hadoop.yarn.server.federation.policies.manager.PriorityBroadcastPolicyManager": - break; - default: - throw new YarnException("Unknown PolicyManager"); - } - } - /** * Determines whether the given value is a number. * diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RouterCLI.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RouterCLI.java index c8f7efe5d8ea1..2da584f9d61bb 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RouterCLI.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RouterCLI.java @@ -75,7 +75,6 @@ import static org.apache.hadoop.yarn.server.api.protocolrecords.FederationQueueWeight.checkHeadRoomAlphaValid; import static org.apache.hadoop.yarn.server.api.protocolrecords.FederationQueueWeight.checkSubClusterQueueWeightRatioValid; -import static org.apache.hadoop.yarn.server.api.protocolrecords.FederationQueueWeight.checkPolicyManagerValid; public class RouterCLI extends Configured implements Tool { @@ -635,8 +634,6 @@ protected SaveFederationQueuePolicyRequest parsePolicy(String policy) throws Yar FederationQueueWeight.newInstance(routerWeight, amrmWeight, headroomalpha); String policyManager = getConf().get(YarnConfiguration.FEDERATION_POLICY_MANAGER, YarnConfiguration.DEFAULT_FEDERATION_POLICY_MANAGER); - checkPolicyManagerValid(policyManager); - SaveFederationQueuePolicyRequest request = SaveFederationQueuePolicyRequest.newInstance( queue, federationQueueWeight, policyManager); @@ -657,11 +654,6 @@ protected SaveFederationQueuePolicyRequest parsePolicy(String policy) throws Yar */ protected int parseXml2PoliciesAndBatchSavePolicies(String policiesXml) { try { - - String policyManager = getConf().get(YarnConfiguration.FEDERATION_POLICY_MANAGER, - YarnConfiguration.DEFAULT_FEDERATION_POLICY_MANAGER); - checkPolicyManagerValid(policyManager); - List federationQueueWeightsList = parsePoliciesByXml(policiesXml); MemoryPageUtils memoryPageUtils = new MemoryPageUtils<>(20); federationQueueWeightsList.forEach(federationQueueWeight -> @@ -734,6 +726,7 @@ protected List parsePoliciesByXml(String policiesXml) String policyManager = getConf().get(YarnConfiguration.FEDERATION_POLICY_MANAGER, YarnConfiguration.DEFAULT_FEDERATION_POLICY_MANAGER); + LOG.debug("Queue: {}, AmrmPolicyWeights: {}, RouterWeight: {}, HeadroomAlpha: {}.", queueName, amrmWeight, routerWeight, headroomAlpha); diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/RouterServerUtil.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/RouterServerUtil.java index 130503065d6b9..992636cc023da 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/RouterServerUtil.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/RouterServerUtil.java @@ -815,4 +815,12 @@ public static boolean isRouterWebProxyEnable(Configuration conf) { return conf.getBoolean(YarnConfiguration.ROUTER_WEBAPP_PROXY_ENABLE, YarnConfiguration.DEFAULT_ROUTER_WEBAPP_PROXY_ENABLE); } + + public static boolean checkPolicyManagerValid(String policyManager, + List supportWeightList) throws YarnException { + if (supportWeightList.contains(policyManager)) { + return true; + } + return false; + } } \ No newline at end of file diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/FederationRMAdminInterceptor.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/FederationRMAdminInterceptor.java index 30b36909fb6d8..ee5f6c3cd4e2a 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/FederationRMAdminInterceptor.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/FederationRMAdminInterceptor.java @@ -72,6 +72,8 @@ import org.apache.hadoop.yarn.server.api.protocolrecords.QueryFederationQueuePoliciesRequest; import org.apache.hadoop.yarn.server.api.protocolrecords.QueryFederationQueuePoliciesResponse; import org.apache.hadoop.yarn.server.federation.failover.FederationProxyProviderUtil; +import org.apache.hadoop.yarn.server.federation.policies.manager.PriorityBroadcastPolicyManager; +import org.apache.hadoop.yarn.server.federation.policies.manager.WeightedLocalityPolicyManager; import org.apache.hadoop.yarn.server.federation.store.records.SubClusterId; import org.apache.hadoop.yarn.server.federation.store.records.SubClusterIdInfo; import org.apache.hadoop.yarn.server.federation.store.records.SubClusterInfo; @@ -89,6 +91,7 @@ import java.io.IOException; import java.nio.ByteBuffer; import java.util.List; +import java.util.Arrays; import java.util.ArrayList; import java.util.Map; import java.util.HashMap; @@ -104,6 +107,8 @@ import java.util.concurrent.ConcurrentHashMap; import java.util.stream.Collectors; +import static org.apache.hadoop.yarn.server.router.RouterServerUtil.checkPolicyManagerValid; + public class FederationRMAdminInterceptor extends AbstractRMAdminRequestInterceptor { private static final Logger LOG = @@ -112,6 +117,10 @@ public class FederationRMAdminInterceptor extends AbstractRMAdminRequestIntercep private static final String COMMA = ","; private static final String COLON = ":"; + private static final List SUPPORT_WEIGHT_MANAGERS = + new ArrayList<>(Arrays.asList(WeightedLocalityPolicyManager.class.getSimpleName(), + PriorityBroadcastPolicyManager.class.getSimpleName())); + private Map adminRMProxies; private FederationStateStoreFacade federationFacade; private final Clock clock = new MonotonicClock(); @@ -921,6 +930,13 @@ public SaveFederationQueuePolicyResponse saveFederationQueuePolicy( RouterServerUtil.logAndThrowException("Missing Queue information.", null); } + String policyManagerClassName = request.getPolicyManagerClassName(); + if (!checkPolicyManagerValid(policyManagerClassName, SUPPORT_WEIGHT_MANAGERS)) { + routerMetrics.incrSaveFederationQueuePolicyFailedRetrieved(); + RouterServerUtil.logAndThrowException(policyManagerClassName + + "does not support the use of queue weights.", null); + } + String amRmWeight = federationQueueWeight.getAmrmWeight(); FederationQueueWeight.checkSubClusterQueueWeightRatioValid(amRmWeight); @@ -932,9 +948,6 @@ public SaveFederationQueuePolicyResponse saveFederationQueuePolicy( try { long startTime = clock.getTime(); - // Step1, get parameters. - String policyManagerClassName = request.getPolicyManagerClassName(); - // Step2, parse amRMPolicyWeights. Map amRMPolicyWeights = getSubClusterWeightMap(amRmWeight); @@ -1308,6 +1321,12 @@ private void saveFederationQueuePolicy(FederationQueueWeight federationQueueWeig RouterServerUtil.logAndThrowException("Missing PolicyManagerClassName information.", null); } + if (!checkPolicyManagerValid(policyManagerClassName, SUPPORT_WEIGHT_MANAGERS)) { + routerMetrics.incrSaveFederationQueuePolicyFailedRetrieved(); + RouterServerUtil.logAndThrowException(policyManagerClassName + + "does not support the use of queue weights.", null); + } + String amRmWeight = federationQueueWeight.getAmrmWeight(); FederationQueueWeight.checkSubClusterQueueWeightRatioValid(amRmWeight); From 21a77e9c6bc71df560efc6b66399a61ab7ec7996 Mon Sep 17 00:00:00 2001 From: slfan1989 Date: Wed, 22 Nov 2023 00:34:39 +0800 Subject: [PATCH 3/4] YARN-11614. Fix CheckStyle. --- .../rmadmin/FederationRMAdminInterceptor.java | 7 ++++--- .../TestFederationRMAdminInterceptor.java | 18 ++++++++++++++---- 2 files changed, 18 insertions(+), 7 deletions(-) diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/FederationRMAdminInterceptor.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/FederationRMAdminInterceptor.java index abed384450d7e..230308e361ff2 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/FederationRMAdminInterceptor.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/FederationRMAdminInterceptor.java @@ -76,6 +76,7 @@ import org.apache.hadoop.yarn.server.api.protocolrecords.DeleteFederationApplicationResponse; import org.apache.hadoop.yarn.server.federation.failover.FederationProxyProviderUtil; import org.apache.hadoop.yarn.server.federation.policies.manager.PriorityBroadcastPolicyManager; +import org.apache.hadoop.yarn.server.federation.policies.manager.WeightedHomePolicyManager; import org.apache.hadoop.yarn.server.federation.policies.manager.WeightedLocalityPolicyManager; import org.apache.hadoop.yarn.server.federation.store.records.SubClusterId; import org.apache.hadoop.yarn.server.federation.store.records.SubClusterIdInfo; @@ -121,8 +122,8 @@ public class FederationRMAdminInterceptor extends AbstractRMAdminRequestIntercep private static final String COLON = ":"; private static final List SUPPORT_WEIGHT_MANAGERS = - new ArrayList<>(Arrays.asList(WeightedLocalityPolicyManager.class.getSimpleName(), - PriorityBroadcastPolicyManager.class.getSimpleName())); + new ArrayList<>(Arrays.asList(WeightedLocalityPolicyManager.class.getName(), + PriorityBroadcastPolicyManager.class.getName(), WeightedHomePolicyManager.class.getName())); private Map adminRMProxies; private FederationStateStoreFacade federationFacade; @@ -937,7 +938,7 @@ public SaveFederationQueuePolicyResponse saveFederationQueuePolicy( if (!checkPolicyManagerValid(policyManagerClassName, SUPPORT_WEIGHT_MANAGERS)) { routerMetrics.incrSaveFederationQueuePolicyFailedRetrieved(); RouterServerUtil.logAndThrowException(policyManagerClassName + - "does not support the use of queue weights.", null); + " does not support the use of queue weights.", null); } String amRmWeight = federationQueueWeight.getAmrmWeight(); diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/rmadmin/TestFederationRMAdminInterceptor.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/rmadmin/TestFederationRMAdminInterceptor.java index 62f1eee845b56..77abbbbeac992 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/rmadmin/TestFederationRMAdminInterceptor.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/rmadmin/TestFederationRMAdminInterceptor.java @@ -643,15 +643,25 @@ public void testSaveFederationQueuePolicyErrorRequest() throws Exception { LambdaTestUtils.intercept(YarnException.class, "Missing Queue information.", () -> interceptor.saveFederationQueuePolicy(request)); - // routerWeight / amrmWeight - // The sum of the routerWeight is not equal to 1. + // PolicyManager needs to support weight FederationQueueWeight federationQueueWeight2 = FederationQueueWeight.newInstance( "SC-1:0.7,SC-2:0.3", "SC-1:0.8,SC-2:0.3", "1.0"); SaveFederationQueuePolicyRequest request2 = - SaveFederationQueuePolicyRequest.newInstance("root.a", federationQueueWeight2, "-"); + SaveFederationQueuePolicyRequest.newInstance("root.a", federationQueueWeight2, "TestPolicyManager"); LambdaTestUtils.intercept(YarnException.class, - "The sum of ratios for all subClusters must be equal to 1.", + "TestPolicyManager does not support the use of queue weights.", () -> interceptor.saveFederationQueuePolicy(request2)); + + // routerWeight / amrmWeight + // The sum of the routerWeight is not equal to 1. + String policyTypeName = WeightedLocalityPolicyManager.class.getCanonicalName(); + FederationQueueWeight federationQueueWeight3 = FederationQueueWeight.newInstance( + "SC-1:0.7,SC-2:0.3", "SC-1:0.8,SC-2:0.3", "1.0"); + SaveFederationQueuePolicyRequest request3 = + SaveFederationQueuePolicyRequest.newInstance("root.a", federationQueueWeight3, policyTypeName); + LambdaTestUtils.intercept(YarnException.class, + "The sum of ratios for all subClusters must be equal to 1.", + () -> interceptor.saveFederationQueuePolicy(request3)); } @Test From d6914ec9d148c662ccb8a02621e4d1bf43540112 Mon Sep 17 00:00:00 2001 From: slfan1989 Date: Sun, 26 Nov 2023 09:29:33 +0800 Subject: [PATCH 4/4] YARN-11614. Fix CheckStyle. --- .../router/rmadmin/TestFederationRMAdminInterceptor.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/rmadmin/TestFederationRMAdminInterceptor.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/rmadmin/TestFederationRMAdminInterceptor.java index 77abbbbeac992..a1339e419040a 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/rmadmin/TestFederationRMAdminInterceptor.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/rmadmin/TestFederationRMAdminInterceptor.java @@ -647,7 +647,8 @@ public void testSaveFederationQueuePolicyErrorRequest() throws Exception { FederationQueueWeight federationQueueWeight2 = FederationQueueWeight.newInstance( "SC-1:0.7,SC-2:0.3", "SC-1:0.8,SC-2:0.3", "1.0"); SaveFederationQueuePolicyRequest request2 = - SaveFederationQueuePolicyRequest.newInstance("root.a", federationQueueWeight2, "TestPolicyManager"); + SaveFederationQueuePolicyRequest.newInstance("root.a", federationQueueWeight2, + "TestPolicyManager"); LambdaTestUtils.intercept(YarnException.class, "TestPolicyManager does not support the use of queue weights.", () -> interceptor.saveFederationQueuePolicy(request2)); @@ -658,7 +659,8 @@ public void testSaveFederationQueuePolicyErrorRequest() throws Exception { FederationQueueWeight federationQueueWeight3 = FederationQueueWeight.newInstance( "SC-1:0.7,SC-2:0.3", "SC-1:0.8,SC-2:0.3", "1.0"); SaveFederationQueuePolicyRequest request3 = - SaveFederationQueuePolicyRequest.newInstance("root.a", federationQueueWeight3, policyTypeName); + SaveFederationQueuePolicyRequest.newInstance("root.a", federationQueueWeight3, + policyTypeName); LambdaTestUtils.intercept(YarnException.class, "The sum of ratios for all subClusters must be equal to 1.", () -> interceptor.saveFederationQueuePolicy(request3));