Skip to content

HADOOP-18627 Stronger wording in 'secure mode' intro #5406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 17, 2023
Merged

HADOOP-18627 Stronger wording in 'secure mode' intro #5406

merged 3 commits into from
Feb 17, 2023

Conversation

@raboof
Copy link
Member

@raboof raboof commented Feb 15, 2023

Description of PR

Make it more clear that when exposing Hadoop to untrusted users, 'secure mode' is not optional.

How was this patch tested?

n/a

@raboof
HADOOP-18627 Stronger wording in 'secure mode' intro
459719e 
Make it more clear that when exposing Hadoop to untrusted users, 'secure mode'
is not optional.
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 50s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 markdownlint 0m 1s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 mvninstall 52m 4s trunk passed
+1 💚 mvnsite 1m 30s trunk passed
+1 💚 shadedclient 79m 26s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 8s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 1m 21s the patch passed
+1 💚 shadedclient 27m 7s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
110m 54s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5406/1/artifact/out/Dockerfile
GITHUB PR #5406
Optional Tests dupname asflicense mvnsite codespell detsecrets markdownlint
uname Linux cec8197a2d0f 4.15.0-197-generic #208-Ubuntu SMP Tue Nov 1 17:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 459719e
Max. process+thread count 534 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5406/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

steveloughran
steveloughran reviewed Feb 15, 2023
View reviewed changes
Copy link
Contributor

@steveloughran steveloughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the extra text, but we should maybe make it even clearer about deployments and the default accessibility "unless you do something your cluster is exposed to everyone else on the same network. in cloud that is a lot"

steveloughran
steveloughran approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@steveloughran steveloughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 after my tuning; merging everywhere

@steveloughran steveloughran merged commit 02fd87a into apache:trunk Feb 17, 2023
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ patch 0m 21s #5406 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.
Subsystem Report/Notes
GITHUB PR #5406
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5406/2/console
versions git=2.17.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ patch 0m 21s #5406 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.
Subsystem Report/Notes
GITHUB PR #5406
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5406/3/console
versions git=2.17.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

asfgit pushed a commit that referenced this pull request Feb 17, 2023
@raboof @steveloughran
HADOOP-18627. Add stronger wording in 'secure mode' introduction (#5406)
274f91a 
Make it more clear that when deploying Hadoop 'secure mode' is generally not optional.

Contributed by Arnout Engelen
asfgit pushed a commit that referenced this pull request Feb 17, 2023
@raboof @steveloughran
HADOOP-18627. Add stronger wording in 'secure mode' introduction (#5406)
477f17b 
Make it more clear that when deploying Hadoop 'secure mode' is generally not optional.

Contributed by Arnout Engelen
ferdelyi pushed a commit to ferdelyi/hadoop that referenced this pull request May 26, 2023
@raboof @ferdelyi
HADOOP-18627. Add stronger wording in 'secure mode' introduction (apa…
800840e 
…che#5406)


Make it more clear that when deploying Hadoop 'secure mode' is generally not optional.

Contributed by Arnout Engelen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steveloughran steveloughran steveloughran approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@raboof @hadoop-yetus @steveloughran