From 1e23bc2f0896ac7c817cba456f460923dd773449 Mon Sep 17 00:00:00 2001 From: skysiders Date: Thu, 24 Feb 2022 13:25:15 +0800 Subject: [PATCH 1/2] MAPREDUCE-7372 MapReduce set permission too late in copyJar method MAPREDUCE-7372.setReplication needs write permission , if umask too restrict , the project will fail, so we need to adjust the order. --- .../java/org/apache/hadoop/mapreduce/JobResourceUploader.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobResourceUploader.java b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobResourceUploader.java index e16a0d0bb0edc..2802a8d2ecb07 100644 --- a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobResourceUploader.java +++ b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobResourceUploader.java @@ -783,9 +783,9 @@ private URI useSharedCache(URI sourceFile, String resourceName, void copyJar(Path originalJarPath, Path submitJarFile, short replication) throws IOException { jtFs.copyFromLocalFile(originalJarPath, submitJarFile); - jtFs.setReplication(submitJarFile, replication); jtFs.setPermission(submitJarFile, new FsPermission( JobSubmissionFiles.JOB_FILE_PERMISSION)); + jtFs.setReplication(submitJarFile, replication); } private void addLog4jToDistributedCache(Job job, Path jobSubmitDir) From 684b38e4f858d21dcd87021f519f0c41537c08a7 Mon Sep 17 00:00:00 2001 From: skysiders Date: Thu, 21 Jul 2022 12:48:30 +0800 Subject: [PATCH 2/2] add comment --- .../java/org/apache/hadoop/mapreduce/JobResourceUploader.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobResourceUploader.java b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobResourceUploader.java index 2802a8d2ecb07..6a3cb80a5ed98 100644 --- a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobResourceUploader.java +++ b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobResourceUploader.java @@ -783,6 +783,8 @@ private URI useSharedCache(URI sourceFile, String resourceName, void copyJar(Path originalJarPath, Path submitJarFile, short replication) throws IOException { jtFs.copyFromLocalFile(originalJarPath, submitJarFile); + // The operation of setReplication requires certain permissions + // so we need to make sure it has enough permissions jtFs.setPermission(submitJarFile, new FsPermission( JobSubmissionFiles.JOB_FILE_PERMISSION)); jtFs.setReplication(submitJarFile, replication);