HADOOP-17379. AbstractS3ATokenIdentifier to set issue date == now. #2466
Conversation
|
cc. @steveloughran Appreciate your review. Thanks! |
|
Btw, while we can't set max date on AbstractS3ATokenIdentifier, there looks to be the chance for SessionTokenIdentifier to set max date as same as expiry time if marshalledCredentials is provided. Would it make sense? I also have the fix for this, though I'm not 100% sure my theory is correct so minimized the fix for HADOOP-17379. If the fix makes sense, either updating the PR or having a separate JIRA issue is fine for me. Please guide which is preferred for you. |
steveloughran
added
bug
fs/s3
make it a separate JIRA, as that will need more thinking about. for this one, +1 as is |
|
patch is in trunk; not in branch-3.3 just yet...soon |
…2466) Unless you explicitly set it, the issue date of a delegation token identifier is 0, which confuses spark renewal (SPARK-33440). This patch makes sure that all S3A DT identifiers have the current time as issue date, fixing the problem as far as S3A tokens are concerned. Contributed by Jungtaek Lim. Change-Id: Ic80ac7895612a1aa669459c73a78a9c17ecf0c0d
|
Thanks for the quick reviewing and merging! |
|
Thank you for this, @HeartSaVioR and @steveloughran . |
…e == now. (apache#2466) Unless you explicitly set it, the issue date of a delegation token identifier is 0, which confuses spark renewal (SPARK-33440). This patch makes sure that all S3A DT identifiers have the current time as issue date, fixing the problem as far as S3A tokens are concerned. Contributed by Jungtaek Lim. Change-Id: Ib365f5b3f14d4b400ebdc232c9e270d889507064
3 participants
This patch ensures that all token identifiers extending AbstractS3ATokenIdentifier to have issue date as the time the identifier instance is created.