From e304b83c42215ecd501157bfcb6938144b6f06ff Mon Sep 17 00:00:00 2001 From: Steve Loughran Date: Fri, 24 Jan 2020 14:37:05 +0000 Subject: [PATCH] HADOOP-16827. TestHarFileSystem.testInheritedMethodsImplemented broken. This is a regression caused by HADOOP-16759. The test TestHarFileSystem uses introspection to verify that HarFileSystem Does not implement methods to which there is a suitable implementation in the base FileSystem class. Because of the way it checks this, refactoring (protected) FileSystem methods in an IDE do not automatically change the probes in TestHarFileSystem. The changes in HADOOP-16759 did exactly that, and somehow managed to get through the build/test process without this being noticed. This patch fixes that failure. Caused by and fixed by Steve Loughran. Change-Id: If60d9c97058242871c02ad1addd424478f84f446 --- .../java/org/apache/hadoop/fs/TestHarFileSystem.java | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystem.java b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystem.java index 6fc777b984005..e1d49f20cf6fa 100644 --- a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystem.java +++ b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestHarFileSystem.java @@ -19,6 +19,7 @@ package org.apache.hadoop.fs; import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.impl.OpenFileParameters; import org.apache.hadoop.fs.permission.AclEntry; import org.apache.hadoop.fs.permission.AclStatus; import org.apache.hadoop.fs.permission.FsAction; @@ -246,15 +247,11 @@ FutureDataInputStreamBuilder openFile(PathHandle pathHandle) CompletableFuture openFileWithOptions( PathHandle pathHandle, - Set mandatoryKeys, - Configuration options, - int bufferSize) throws IOException; + OpenFileParameters parameters) throws IOException; CompletableFuture openFileWithOptions( Path path, - Set mandatoryKeys, - Configuration options, - int bufferSize) throws IOException; + OpenFileParameters parameters) throws IOException; } @Test