Skip to content

Commit 970d1bf

Browse files
committed
HADOOP-18889. javadocs and line endings
...i understand now. @see must come last in the javadocs Change-Id: If7464a7d13bbd29fd5a000b2068a2aa536df2d66
1 parent 3693ff6 commit 970d1bf

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ARetryPolicy.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454

5555
/**
5656
* The S3A request retry policy.
57-
*
57+
* <p>
5858
* This uses the retry options in the configuration file to determine retry
5959
* count and delays for "normal" retries and separately, for throttling;
6060
* the latter is best handled for longer with an exponential back-off.
@@ -69,7 +69,7 @@
6969
* For non-idempotent operations, only failures due to throttling or
7070
* from failures which are known to only arise prior to talking to S3
7171
* are retried.
72-
*
72+
* <p>
7373
* The retry policy is all built around that of the normal IO exceptions,
7474
* particularly those extracted from
7575
* {@link S3AUtils#translateException(String, Path, SdkException)}.
@@ -79,13 +79,13 @@
7979
* <p>
8080
* Put differently: this retry policy aims to work for handlers of the
8181
* untranslated exceptions, as well as the translated ones.
82-
* @see <a href="http://docs.aws.amazon.com/AmazonS3/latest/API/ErrorResponses.html">S3 Error responses</a>
83-
* @see <a href="http://docs.aws.amazon.com/AmazonS3/latest/dev/ErrorBestPractices.html"> Amazon S3 Error Best Practices </a>
8482
* <p>
8583
* Note that because delete is considered idempotent, all s3a operations currently
8684
* declare themselves idempotent.
8785
* This means the retry policy here is more complex than it needs to be -but it
8886
* does force us to consider when retrying operations would not be safe.
87+
* @see <a href="http://docs.aws.amazon.com/AmazonS3/latest/API/ErrorResponses.html">S3 Error responses</a>
88+
* @see <a href="http://docs.aws.amazon.com/AmazonS3/latest/dev/ErrorBestPractices.html"> Amazon S3 Error Best Practices</a>
8989
*/
9090
@SuppressWarnings("visibilitymodifier") // we want a struct of finals, for real.
9191
public class S3ARetryPolicy implements RetryPolicy {

hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/troubleshooting_s3a.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -915,7 +915,6 @@ org.apache.hadoop.fs.s3a.AWSS3IOException: innerMkdirs on /test:
915915
Request ID: CA89F276B3394565),
916916
S3 Extended Request ID: ncz0LWn8zor1cUO2fQ7gc5eyqOk3YfyQLDn2OQNoe5Zj/GqDLggUYz9QY7JhdZHdBaDTh+TL5ZQ=:
917917
Invalid arn (Service: Amazon S3; Status Code: 400; Error Code: KMS.NotFoundException; Request ID: CA89F276B3394565)
918-
919918
```
920919

921920
Possible causes:
@@ -1055,7 +1054,6 @@ able to generate unique data key for encryption.
10551054
Caused by: software.amazon.awssdk.services.kms.mode.InvalidKeyUsageException:
10561055
You cannot generate a data key with an asymmetric CMK
10571056
(Service: AWSKMS; Status Code: 400; Error Code: InvalidKeyUsageException; Request ID: 93609c15-e490-4035-8390-f4396f0d90bf; Proxy: null)
1058-
10591057
```
10601058

10611059
Generate a Symmetric Key in the same region as your S3 storage for CSE-KMS to
@@ -1141,7 +1139,6 @@ org.apache.hadoop.fs.s3a.UnknownStoreException: `s3a://random-bucket-7d9217b0-b4
11411139
(Service: S3, Status Code: 404, Request ID: RD254TC8EVDV98AK): null
11421140
(Service: S3, Status Code: 404, Request ID: RD254TC8EVDV98AK, Extended Request ID: 49F5CO1IKavFsz+VBecf2uwZeNVar3InHkdIrONvAK5yQ73gqZ1hFoAEMo8/x5wRNe3OXO3aebvZkev2bS81kw==)
11431141
(Service: S3, Status Code: 404, Request ID: RD254TC8EVDV98AK)
1144-
11451142
```
11461143

11471144
Check the URI is correct, and that the bucket actually exists.
@@ -1368,15 +1365,12 @@ connections more frequently.
13681365
The unspecified location constraint is incompatible for the region specific
13691366
endpoint this request was sent to.
13701367
(Service: Amazon S3; Status Code: 400; Error Code: IllegalLocationConstraintException;
1371-
1372-
13731368
...
13741369
Cause: S3Exception:
13751370
The unspecified location constraint is incompatible for the region specific endpoint
13761371
this request was sent to. (Service: Amazon S3; Status Code: 400; Error Code: IllegalLocationConstraintException;
13771372
Request ID: EEBC5A08BCB3A645)
13781373
1379-
...
13801374
```
13811375

13821376
Something has been trying to write data to "/".

0 commit comments

Comments
 (0)