Skip to content

Commit 3cdfd16

Browse files
author
Ashutosh Gupta
committed
Added unit test
1 parent 55052eb commit 3cdfd16

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/ganglia/AbstractGangliaSink.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import java.util.Map;
2828

2929
import org.apache.commons.configuration2.SubsetConfiguration;
30+
import org.apache.hadoop.classification.VisibleForTesting;
3031
import org.apache.hadoop.metrics2.MetricsSink;
3132
import org.apache.hadoop.metrics2.util.Servers;
3233
import org.apache.hadoop.net.DNS;
@@ -79,6 +80,11 @@ public abstract class AbstractGangliaSink implements MetricsSink {
7980
private int offset;
8081
private boolean supportSparseMetrics = SUPPORT_SPARSE_METRICS_DEFAULT;
8182

83+
@VisibleForTesting
84+
public List<? extends SocketAddress> getMetricsServers() {
85+
return metricsServers;
86+
}
87+
8288
/**
8389
* Used for visiting Metrics
8490
*/

hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/sink/ganglia/TestGangliaSink.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,4 +78,14 @@ public void testShouldSetMulticastSocketTtl() throws Exception {
7878
int ttl = ((MulticastSocket) socket).getTimeToLive();
7979
assertEquals("Did not set TTL", 3, ttl);
8080
}
81+
82+
@Test
83+
public void testMultipleMetricsServers() {
84+
SubsetConfiguration conf =
85+
new ConfigBuilder().add("test.sink.ganglia.servers", "server1,server2")
86+
.subset("test.sink.ganglia");
87+
GangliaSink30 gangliaSink = new GangliaSink30();
88+
gangliaSink.init(conf);
89+
assertEquals(2, gangliaSink.getMetricsServers().size());
90+
}
8191
}

0 commit comments

Comments
 (0)