HADOOP-16237. Fix new findbugs issues after updating guava to 27.0-jre.

Gabor Bota · steveloughran · commit 1943db557124 · 2019-04-12T18:28:38.000-07:00
Author:    Gabor Bota &lt;gabor.bota@cloudera.com&gt;
diff --git a/hadoop-common-project/hadoop-kms/dev-support/findbugsExcludeFile.xml b/hadoop-common-project/hadoop-kms/dev-support/findbugsExcludeFile.xml
@@ -15,6 +15,14 @@
    limitations under the License.
 -->
 <FindBugsFilter>
+
+  <!-- The called method signature is isNullOrEmpty(@Nullable String string) in guava 27, so this should be ignored. -->
+  <Match>
+    <Class name="org.apache.hadoop.crypto.key.kms.server.KMSAudit"/>
+    <Method name="op" />
+    <Bug pattern="NP_NULL_PARAM_DEREF"/>
+  </Match>
+
   <!--
     Findbug is complaining about System.out being NULL
   -->
diff --git a/hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml b/hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml
@@ -660,4 +660,41 @@
     <Bug pattern="EI_EXPOSE_REP" />
   </Match>
 
+  <!-- The called method signature is String emptyToNull(@Nullable String string) in guava 27, so this should be ignored -->
+  <Match>
+    <Class name="org.apache.hadoop.yarn.server.nodemanager.NodeHealthCheckerService"/>
+    <Method name="getHealthReport" />
+    <Bug pattern="NP_NULL_PARAM_DEREF"/>
+  </Match>
+
+  <!-- The variable is not used, but it's defined for the document model. -->
+  <Match>
+    <Class name="org.apache.hadoop.yarn.server.timelineservice.documentstore.collection.document.entity.TimelineEventSubDoc"/>
+    <Method name="setValid" />
+    <Bug pattern="URF_UNREAD_FIELD"/>
+  </Match>
+
+  <!-- The variable is not used, but it's defined for the document model. -->
+  <Match>
+    <Class name="org.apache.hadoop.yarn.server.timelineservice.documentstore.collection.document.entity.TimelineMetricSubDoc"/>
+    <Method name="setValid" />
+    <Bug pattern="URF_UNREAD_FIELD"/>
+  </Match>
+
+  <!-- The called method signature is public boolean set(@Nullable V value) in guava 27, so this should be ignored -->
+  <Match>
+    <Class name="org.apache.hadoop.yarn.server.resourcemanager.recovery.RMStateStore$UpdateAppTransition"/>
+    <Method name="transition" />
+    <Local name="result" />
+    <Bug pattern="NP_NONNULL_PARAM_VIOLATION"/>
+  </Match>
+
+  <!-- The called method signature is public boolean set(@Nullable V value) in guava 27, so this should be ignored -->
+  <Match>
+    <Class name="org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler"/>
+    <Method name="updateApplicationPriority" />
+    <Local name="result" />
+    <Bug pattern="NP_NONNULL_PARAM_VIOLATION"/>
+  </Match>
+
 </FindBugsFilter>
diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-documentstore/src/main/java/org/apache/hadoop/yarn/server/timelineservice/documentstore/collection/document/entity/TimelineEntityDocument.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-documentstore/src/main/java/org/apache/hadoop/yarn/server/timelineservice/documentstore/collection/document/entity/TimelineEntityDocument.java
@@ -138,14 +138,18 @@ public Map<String, Set<TimelineMetricSubDoc>> getMetrics() {
   }
 
   public void setMetrics(Map<String, Set<TimelineMetricSubDoc>> metrics) {
-    for (String metricId : metrics.keySet()) {
-      for(TimelineMetricSubDoc metricSubDoc : metrics.get(metricId)) {
+    for (Map.Entry<String, Set<TimelineMetricSubDoc>> metricEntry :
+        metrics.entrySet()) {
+      final String metricId = metricEntry.getKey();
+      final Set<TimelineMetricSubDoc> metricValue = metricEntry.getValue();
+
+      for(TimelineMetricSubDoc metricSubDoc : metricValue) {
         timelineEntity.addMetric(metricSubDoc.fetchTimelineMetric());
       }
       if (this.metrics.containsKey(metricId)) {
-        this.metrics.get(metricId).addAll(metrics.get(metricId));
+        this.metrics.get(metricId).addAll(metricValue);
       } else {
-        this.metrics.put(metricId, new HashSet<>(metrics.get(metricId)));
+        this.metrics.put(metricId, new HashSet<>(metricValue));
       }
     }
   }
@@ -155,14 +159,18 @@ public Map<String, Set<TimelineEventSubDoc>> getEvents() {
   }
 
   public void setEvents(Map<String, Set<TimelineEventSubDoc>> events) {
-    for (String eventId : events.keySet()) {
-      for(TimelineEventSubDoc eventSubDoc: events.get(eventId)) {
+    for (Map.Entry<String, Set<TimelineEventSubDoc>> eventEntry :
+        events.entrySet()) {
+      final String eventId = eventEntry.getKey();
+      final Set<TimelineEventSubDoc> eventValue = eventEntry.getValue();
+
+      for(TimelineEventSubDoc eventSubDoc : eventValue) {
         timelineEntity.addEvent(eventSubDoc.fetchTimelineEvent());
       }
       if (this.events.containsKey(eventId)) {
         this.events.get(eventId).addAll(events.get(eventId));
       } else {
-        this.events.put(eventId, new HashSet<>(events.get(eventId)));
+        this.events.put(eventId, new HashSet<>(eventValue));
       }
     }
   }
diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-documentstore/src/main/java/org/apache/hadoop/yarn/server/timelineservice/documentstore/collection/document/flowrun/FlowRunDocument.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-documentstore/src/main/java/org/apache/hadoop/yarn/server/timelineservice/documentstore/collection/document/flowrun/FlowRunDocument.java
@@ -97,10 +97,14 @@ public void merge(FlowRunDocument flowRunDoc) {
 
   private void aggregateMetrics(
       Map<String, TimelineMetricSubDoc> metricSubDocMap) {
-    for(String metricId : metricSubDocMap.keySet()) {
+    for(Map.Entry<String, TimelineMetricSubDoc> metricEntry :
+        metricSubDocMap.entrySet()) {
+      final String metricId = metricEntry.getKey();
+      final TimelineMetricSubDoc metricValue = metricEntry.getValue();
+
       if (this.metrics.containsKey(metricId)) {
         TimelineMetric incomingMetric =
-            metricSubDocMap.get(metricId).fetchTimelineMetric();
+            metricValue.fetchTimelineMetric();
         TimelineMetric baseMetric =
             this.metrics.get(metricId).fetchTimelineMetric();
         if (incomingMetric.getValues().size() > 0) {
@@ -111,7 +115,7 @@ private void aggregateMetrics(
               baseMetric.getId());
         }
       } else {
-        this.metrics.put(metricId, metricSubDocMap.get(metricId));
+        this.metrics.put(metricId, metricValue);
       }
     }
   }
@@ -135,7 +139,8 @@ private TimelineMetric aggregate(TimelineMetric incomingMetric,
       baseMetric = TimelineMetricOperation.REPLACE
           .aggregate(incomingMetric, baseMetric, null);
     default:
-      //NoOP
+      LOG.warn("Unknown TimelineMetricOperation: {}",
+          baseMetric.getRealtimeAggregationOp());
     }
     return baseMetric;
   }
diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-documentstore/src/main/java/org/apache/hadoop/yarn/server/timelineservice/documentstore/reader/cosmosdb/CosmosDBDocumentStoreReader.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-documentstore/src/main/java/org/apache/hadoop/yarn/server/timelineservice/documentstore/reader/cosmosdb/CosmosDBDocumentStoreReader.java
@@ -49,7 +49,7 @@ public class CosmosDBDocumentStoreReader<TimelineDoc extends TimelineDocument>
       .getLogger(CosmosDBDocumentStoreReader.class);
   private static final int DEFAULT_DOCUMENTS_SIZE = 1;
 
-  private static DocumentClient client;
+  private static volatile DocumentClient client;
   private final String databaseName;
   private final static String COLLECTION_LINK = "/dbs/%s/colls/%s";
   private final static String SELECT_TOP_FROM_COLLECTION = "SELECT TOP %d * " +
diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-documentstore/src/main/java/org/apache/hadoop/yarn/server/timelineservice/documentstore/writer/cosmosdb/CosmosDBDocumentStoreWriter.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-documentstore/src/main/java/org/apache/hadoop/yarn/server/timelineservice/documentstore/writer/cosmosdb/CosmosDBDocumentStoreWriter.java
@@ -51,7 +51,7 @@ public class CosmosDBDocumentStoreWriter<TimelineDoc extends TimelineDocument>
   private static final Logger LOG = LoggerFactory
       .getLogger(CosmosDBDocumentStoreWriter.class);
 
-  private static DocumentClient client;
+  private static volatile DocumentClient client;
   private final String databaseName;
   private static final PerNodeAggTimelineCollectorMetrics METRICS =
       PerNodeAggTimelineCollectorMetrics.getInstance();

Original file line number	Diff line number	Diff line change
`@@ -138,14 +138,18 @@ public Map<String, Set<TimelineMetricSubDoc>> getMetrics() {`
`138`	`138`	`}`
`139`	`139`
`140`	`140`	`public void setMetrics(Map<String, Set<TimelineMetricSubDoc>> metrics) {`
`141`		`- for (String metricId : metrics.keySet()) {`
`142`		`- for(TimelineMetricSubDoc metricSubDoc : metrics.get(metricId)) {`
	`141`	`+ for (Map.Entry<String, Set<TimelineMetricSubDoc>> metricEntry :`
	`142`	`+ metrics.entrySet()) {`
	`143`	`+ final String metricId = metricEntry.getKey();`
	`144`	`+ final Set<TimelineMetricSubDoc> metricValue = metricEntry.getValue();`
	`145`	`+`
	`146`	`+ for(TimelineMetricSubDoc metricSubDoc : metricValue) {`
`143`	`147`	`timelineEntity.addMetric(metricSubDoc.fetchTimelineMetric());`
`144`	`148`	`}`
`145`	`149`	`if (this.metrics.containsKey(metricId)) {`
`146`		`- this.metrics.get(metricId).addAll(metrics.get(metricId));`
	`150`	`+ this.metrics.get(metricId).addAll(metricValue);`
`147`	`151`	`} else {`
`148`		`- this.metrics.put(metricId, new HashSet<>(metrics.get(metricId)));`
	`152`	`+ this.metrics.put(metricId, new HashSet<>(metricValue));`
`149`	`153`	`}`
`150`	`154`	`}`
`151`	`155`	`}`
`@@ -155,14 +159,18 @@ public Map<String, Set<TimelineEventSubDoc>> getEvents() {`
`155`	`159`	`}`
`156`	`160`
`157`	`161`	`public void setEvents(Map<String, Set<TimelineEventSubDoc>> events) {`
`158`		`- for (String eventId : events.keySet()) {`
`159`		`- for(TimelineEventSubDoc eventSubDoc: events.get(eventId)) {`
	`162`	`+ for (Map.Entry<String, Set<TimelineEventSubDoc>> eventEntry :`
	`163`	`+ events.entrySet()) {`
	`164`	`+ final String eventId = eventEntry.getKey();`
	`165`	`+ final Set<TimelineEventSubDoc> eventValue = eventEntry.getValue();`
	`166`	`+`
	`167`	`+ for(TimelineEventSubDoc eventSubDoc : eventValue) {`
`160`	`168`	`timelineEntity.addEvent(eventSubDoc.fetchTimelineEvent());`
`161`	`169`	`}`
`162`	`170`	`if (this.events.containsKey(eventId)) {`
`163`	`171`	`this.events.get(eventId).addAll(events.get(eventId));`
`164`	`172`	`} else {`
`165`		`- this.events.put(eventId, new HashSet<>(events.get(eventId)));`
	`173`	`+ this.events.put(eventId, new HashSet<>(eventValue));`
`166`	`174`	`}`
`167`	`175`	`}`
`168`	`176`	`}`
Original file line number	Diff line number	Diff line change
`@@ -97,10 +97,14 @@ public void merge(FlowRunDocument flowRunDoc) {`
`97`	`97`
`98`	`98`	`private void aggregateMetrics(`
`99`	`99`	`Map<String, TimelineMetricSubDoc> metricSubDocMap) {`
`100`		`- for(String metricId : metricSubDocMap.keySet()) {`
	`100`	`+ for(Map.Entry<String, TimelineMetricSubDoc> metricEntry :`
	`101`	`+ metricSubDocMap.entrySet()) {`
	`102`	`+ final String metricId = metricEntry.getKey();`
	`103`	`+ final TimelineMetricSubDoc metricValue = metricEntry.getValue();`
	`104`	`+`
`101`	`105`	`if (this.metrics.containsKey(metricId)) {`
`102`	`106`	`TimelineMetric incomingMetric =`
`103`		`- metricSubDocMap.get(metricId).fetchTimelineMetric();`
	`107`	`+ metricValue.fetchTimelineMetric();`
`104`	`108`	`TimelineMetric baseMetric =`
`105`	`109`	`this.metrics.get(metricId).fetchTimelineMetric();`
`106`	`110`	`if (incomingMetric.getValues().size() > 0) {`
`@@ -111,7 +115,7 @@ private void aggregateMetrics(`
`111`	`115`	`baseMetric.getId());`
`112`	`116`	`}`
`113`	`117`	`} else {`
`114`		`- this.metrics.put(metricId, metricSubDocMap.get(metricId));`
	`118`	`+ this.metrics.put(metricId, metricValue);`
`115`	`119`	`}`
`116`	`120`	`}`
`117`	`121`	`}`
`@@ -135,7 +139,8 @@ private TimelineMetric aggregate(TimelineMetric incomingMetric,`
`135`	`139`	`baseMetric = TimelineMetricOperation.REPLACE`
`136`	`140`	`.aggregate(incomingMetric, baseMetric, null);`
`137`	`141`	`default:`
`138`		`- //NoOP`
	`142`	`+ LOG.warn("Unknown TimelineMetricOperation: {}",`
	`143`	`+ baseMetric.getRealtimeAggregationOp());`
`139`	`144`	`}`
`140`	`145`	`return baseMetric;`
`141`	`146`	`}`