Patch for supporting backticks in GenericDialect

[bitemyapp]

This was needed for the Athena SQL parsing I've been doing.

Fixes #632 632

[coveralls]

Pull Request Test Coverage Report for Build 3275858885

• 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.006%) to 85.852%

---

Totals
Change from base Build 3255613260:	0.006%
Covered Lines:	10765
Relevant Lines:	12539

---

💛 - Coveralls

[bitemyapp]

I've pushed a cleaned up version here that should be fine.

[alamb]

Thanks for the contribution @bitemyapp

[alamb]

Given this was a change to the generic Dialect (the default impl) can you also please add a test in parser_generic.rs as well?

[bitemyapp]

Yep, I think that makes sense. Thank you! 3rd kid in as many years born Monday (first daughter!), will get to it in a few days I think.

[alamb]

3rd kid in as many years born Monday (first daughter!

Congratulations and good luck!

[bitemyapp]

@alamb

can you also please add a test in parser_generic.rs as well?

I've added a generic test in the Hive test. parser_common was mostly about "all dialects", this change is just hive and generic. There are other Hive tests testing generic such that I factored out the dialect value creation into a function.

I think the remaining thing here is lifting the backtick out of the trait default implementation out to Hive and Generic's trait impls. What do you think?

[alamb]

Marking as draft so I know it isn't waiting on review anymore

[alamb]

Closing this PR as it is more than 6 months old without activity. Please reopen or make another PR if you plan to keep working on this.