Code review comments

Author: yoavcloud

src/ast/query.rs

@@ -975,7 +975,7 @@ pub enum TableFactor {
         /// [Partition selection](https://dev.mysql.com/doc/refman/8.0/en/partitioning-selection.html), supported by MySQL.
         partitions: Vec<Ident>,
         /// Optional PartiQL JsonPath: <https://partiql.org/dql/from.html>
-        partiql: Option<JsonPath>,
+        json_path: Option<JsonPath>,
     },
     Derived {
         lateral: bool,
@@ -1377,11 +1377,11 @@ impl fmt::Display for TableFactor {
                 version,
                 partitions,
                 with_ordinality,
-                partiql,
+                json_path,
             } => {
                 write!(f, "{name}")?;
-                if let Some(partiql) = partiql {
-                    write!(f, "{partiql}")?;
+                if let Some(json_path) = json_path {
+                    write!(f, "{json_path}")?;
                 }
                 if !partitions.is_empty() {
                     write!(f, "PARTITION ({})", display_comma_separated(partitions))?;

src/parser/mod.rs

@@ -10328,7 +10328,7 @@ impl<'a> Parser<'a> {
         } else {
             let name = self.parse_object_name(true)?;
 
-            let partiql = match self.peek_token().token {
+            let json_path = match self.peek_token().token {
                 Token::LBracket if self.dialect.supports_partiql() => Some(self.parse_json_path()?),
                 _ => None,
             };
@@ -10375,7 +10375,7 @@ impl<'a> Parser<'a> {
                 version,
                 partitions,
                 with_ordinality,
-                partiql,
+                json_path,
             };
 
             while let Some(kw) = self.parse_one_of_keywords(&[Keyword::PIVOT, Keyword::UNPIVOT]) {

src/test_utils.rs

@@ -345,7 +345,7 @@ pub fn table(name: impl Into<String>) -> TableFactor {
         version: None,
         partitions: vec![],
         with_ordinality: false,
-        partiql: None,
+        json_path: None,
     }
 }
 
@@ -361,7 +361,7 @@ pub fn table_with_alias(name: impl Into<String>, alias: impl Into<String>) -> Ta
         version: None,
         partitions: vec![],
         with_ordinality: false,
-        partiql: None,
+        json_path: None,
     }
 }
 

tests/sqlparser_bigquery.rs

@@ -229,7 +229,7 @@ fn parse_delete_statement() {
                     version: None,
                     partitions: vec![],
                     with_ordinality: false,
-                    partiql: None,
+                    json_path: None,
                 },
                 from[0].relation
             );
@@ -1374,7 +1374,7 @@ fn parse_table_identifiers() {
                     version: None,
                     partitions: vec![],
                     with_ordinality: false,
-                    partiql: None,
+                    json_path: None,
                 },
                 joins: vec![]
             },]
@@ -1548,7 +1548,7 @@ fn parse_table_time_travel() {
                 ))),
                 partitions: vec![],
                 with_ordinality: false,
-                partiql: None,
+                json_path: None,
             },
             joins: vec![]
         },]
@@ -1647,7 +1647,7 @@ fn parse_merge() {
                     version: Default::default(),
                     partitions: Default::default(),
                     with_ordinality: false,
-                    partiql: None,
+                    json_path: None,
                 },
                 table
             );
@@ -1663,7 +1663,7 @@ fn parse_merge() {
                     version: Default::default(),
                     partitions: Default::default(),
                     with_ordinality: false,
-                    partiql: None,
+                    json_path: None,
                 },
                 source
             );

tests/sqlparser_clickhouse.rs

@@ -67,7 +67,7 @@ fn parse_map_access_expr() {
                     version: None,
                     partitions: vec![],
                     with_ordinality: false,
-                    partiql: None,
+                    json_path: None,
                 },
                 joins: vec![],
             }],
@@ -173,7 +173,7 @@ fn parse_delimited_identifiers() {
             version,
             with_ordinality: _,
             partitions: _,
-            partiql: _,
+            json_path: _,
         } => {
             assert_eq!(vec![Ident::with_quote('"', "a table")], name.0);
             assert_eq!(Ident::with_quote('"', "alias"), alias.unwrap().name);