This repository was archived by the owner on Jan 9, 2020. It is now read-only.
Refactor for Hadoop conf related code #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@liyinan926 PTAL. Thanks! |
Author
|
Integration Test error is environment related. |
Member
|
rerun integration tests please |
Member
|
LGTM. Will merge once integration tests pass. |
liyinan926
approved these changes
Jan 9, 2018
Member
|
Thank you for your work on this! |
Author
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When doing some refactor for #585 , I find that it will help a lot to do some refactor for Hadoop conf related code. It might be better to split a separate and small PR for it.
(Please fill in changes proposed in this fix)
HadoopConfUtilshadoopUGIfromHadoopConfBootstrapImpl.How was this patch tested?
Unit tests.