This repository was archived by the owner on Jan 9, 2020. It is now read-only.
Shutdown the thread scheduler in LoggingPodStatusWatcher on receiving… #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… job finish event notifications
|
Just tested this and confirmed it indeed fixes the regression. However the regression in spark-on-k8s is looking like a symptom of a regression in the upstream kubernetes-client library where the I think we should still merge this though since it makes the LoggingPodStatusWatcher more resilient to issues like this one. |
ash211
merged commit 84f147b
into
apache-spark-on-k8s:k8s-support-alternate-incremental
|
Thanks @varunkatta for the contribution! |
This was referenced Feb 23, 2017
ash211
pushed a commit
that referenced
this pull request
Mar 8, 2017
… job finish event notifications (#121)
foxish
pushed a commit
that referenced
this pull request
Jul 24, 2017
… job finish event notifications (#121)
ifilonenko
pushed a commit
to ifilonenko/spark
that referenced
this pull request
Feb 25, 2019
… job finish event notifications (apache-spark-on-k8s#121)
ifilonenko
pushed a commit
to ifilonenko/spark
that referenced
this pull request
Feb 25, 2019
…ng-distributedsuite Ignore hanging DistributedSuite
puneetloya
pushed a commit
to puneetloya/spark
that referenced
this pull request
Mar 11, 2019
… job finish event notifications (apache-spark-on-k8s#121)
ifilonenko
pushed a commit
to bloomberg/apache-spark-on-k8s
that referenced
this pull request
Oct 21, 2019
### What changes were proposed in this pull request? Updated kubernetes client. ### Why are the changes needed? https://issues.apache.org/jira/browse/SPARK-27812 https://issues.apache.org/jira/browse/SPARK-27927 We need this fix fabric8io/kubernetes-client#1768 that was released on version 4.6 of the client. The root cause of the problem is better explained in apache#25785 ### Does this PR introduce any user-facing change? Nope, it should be transparent to users ### How was this patch tested? This patch was tested manually using a simple pyspark job ```python from pyspark.sql import SparkSession if __name__ == '__main__': spark = SparkSession.builder.getOrCreate() ``` The expected behaviour of this "job" is that both python's and jvm's process exit automatically after the main runs. This is the case for spark versions <= 2.4. On version 2.4.3, the jvm process hangs because there's a non daemon thread running ``` "OkHttp WebSocket https://10.96.0.1/..." apache-spark-on-k8s#121 prio=5 os_prio=0 tid=0x00007fb27c005800 nid=0x24b waiting on condition [0x00007fb300847000] "OkHttp WebSocket https://10.96.0.1/..." apache-spark-on-k8s#117 prio=5 os_prio=0 tid=0x00007fb28c004000 nid=0x247 waiting on condition [0x00007fb300e4b000] ``` This is caused by a bug on `kubernetes-client` library, which is fixed on the version that we are upgrading to. When the mentioned job is run with this patch applied, the behaviour from spark <= 2.4.3 is restored and both processes terminate successfully Closes apache#26093 from igorcalabria/k8s-client-update. Authored-by: igor.calabria <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120
What changes were proposed in this pull request?
The scheduler inside LoggingPodStatusWatcher doesn't seem to be shutdown after the receiving job finished events. So, I shutdown the scheduler on receiving these events.
How was this patch tested?
Tested manually that job launcher client exits when the spark job succeeds.