Skip to content
This repository was archived by the owner on Jan 9, 2020. It is now read-only.

Commit e24c4af

Browse files
mccheahash211
authored andcommitted
Reorganize packages between v1 work and v2 work (#220)
* Staging server for receiving application dependencies. * Move packages around to split between v1 work and v2 work * Add unit test for file writing * Remove unnecessary main * Add back license header * Minor fixes * Fix integration test with renamed package for client. Fix scalastyle. * Force json serialization to consider the different package. * Revert extraneous log * Fix scalastyle * Remove getting credentials from the API We still want to post them because in the future we can use these credentials to monitor the API server and handle cleaning up the data accordingly. * Generalize to resource staging server outside of Spark * Update code documentation * Val instead of var * Fix build * Fix naming, remove unused import * Move suites from integration test package to core * Use TrieMap instead of locks * Address comments * Fix imports * Change paths, use POST instead of PUT * Use a resource identifier as well as a resource secret
1 parent 3f6e5ea commit e24c4af

30 files changed

+45
-41
lines changed

core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -619,7 +619,7 @@ object SparkSubmit {
619619
}
620620

621621
if (isKubernetesCluster) {
622-
childMainClass = "org.apache.spark.deploy.kubernetes.Client"
622+
childMainClass = "org.apache.spark.deploy.kubernetes.submit.v1.Client"
623623
childArgs += args.primaryResource
624624
childArgs += args.mainClass
625625
childArgs ++= args.childArgs

dev/.rat-excludes

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,4 +103,4 @@ org.apache.spark.scheduler.ExternalClusterManager
103103
org.apache.spark.deploy.yarn.security.ServiceCredentialProvider
104104
spark-warehouse
105105
structured-streaming/*
106-
org.apache.spark.deploy.rest.kubernetes.DriverServiceManager
106+
org.apache.spark.deploy.kubernetes.submit.v1.DriverServiceManager
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
org.apache.spark.deploy.kubernetes.submit.v1.ExternalSuppliedUrisDriverServiceManager
2+
org.apache.spark.deploy.kubernetes.submit.v1.NodePortUrisDriverServiceManager

resource-managers/kubernetes/core/src/main/resources/META-INF/services/org.apache.spark.deploy.rest.kubernetes.DriverServiceManager

Lines changed: 0 additions & 2 deletions
This file was deleted.

resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/config.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ package org.apache.spark.deploy.kubernetes
1919
import java.util.concurrent.TimeUnit
2020

2121
import org.apache.spark.{SPARK_VERSION => sparkVersion}
22-
import org.apache.spark.deploy.rest.kubernetes.NodePortUrisDriverServiceManager
22+
import org.apache.spark.deploy.kubernetes.submit.v1.NodePortUrisDriverServiceManager
2323
import org.apache.spark.internal.config.ConfigBuilder
2424
import org.apache.spark.network.util.ByteUnit
2525

resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/Client.scala renamed to resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/kubernetes/submit/v1/Client.scala

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* See the License for the specific language governing permissions and
1515
* limitations under the License.
1616
*/
17-
package org.apache.spark.deploy.kubernetes
17+
package org.apache.spark.deploy.kubernetes.submit.v1
1818

1919
import java.io.File
2020
import java.security.SecureRandom
@@ -32,8 +32,7 @@ import scala.collection.JavaConverters._
3232
import org.apache.spark.{SparkConf, SparkException}
3333
import org.apache.spark.deploy.kubernetes.config._
3434
import org.apache.spark.deploy.kubernetes.constants._
35-
import org.apache.spark.deploy.rest.{AppResource, ContainerAppResource, KubernetesCreateSubmissionRequest, KubernetesCredentials, RemoteAppResource, UploadedAppResource}
36-
import org.apache.spark.deploy.rest.kubernetes._
35+
import org.apache.spark.deploy.rest.kubernetes.v1.{AppResource, ContainerAppResource, HttpClientUtil, KubernetesCreateSubmissionRequest, KubernetesCredentials, KubernetesFileUtils, KubernetesSparkRestApi, RemoteAppResource, UploadedAppResource}
3736
import org.apache.spark.internal.Logging
3837
import org.apache.spark.util.{ShutdownHookManager, Utils}
3938

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* See the License for the specific language governing permissions and
1515
* limitations under the License.
1616
*/
17-
package org.apache.spark.deploy.rest.kubernetes
17+
package org.apache.spark.deploy.kubernetes.submit.v1
1818

1919
import java.io.{ByteArrayInputStream, File, FileInputStream, FileOutputStream}
2020
import java.util.zip.{GZIPInputStream, GZIPOutputStream}
@@ -26,7 +26,7 @@ import org.apache.commons.compress.utils.CharsetNames
2626
import org.apache.commons.io.IOUtils
2727
import scala.collection.mutable
2828

29-
import org.apache.spark.deploy.rest.TarGzippedData
29+
import org.apache.spark.deploy.rest.kubernetes.v1.TarGzippedData
3030
import org.apache.spark.internal.Logging
3131
import org.apache.spark.util.{ByteBufferOutputStream, Utils}
3232

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,15 @@
1414
* See the License for the specific language governing permissions and
1515
* limitations under the License.
1616
*/
17-
package org.apache.spark.deploy.kubernetes
17+
package org.apache.spark.deploy.kubernetes.submit.v1
1818

1919
import java.io.File
2020

2121
import com.google.common.io.{BaseEncoding, Files}
2222

2323
import org.apache.spark.SparkConf
2424
import org.apache.spark.deploy.kubernetes.config._
25-
import org.apache.spark.deploy.rest.KubernetesCredentials
25+
import org.apache.spark.deploy.rest.kubernetes.v1.KubernetesCredentials
2626
import org.apache.spark.internal.config.OptionalConfigEntry
2727

2828
private[spark] class DriverPodKubernetesCredentialsProvider(sparkConf: SparkConf) {
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@
1414
* See the License for the specific language governing permissions and
1515
* limitations under the License.
1616
*/
17-
18-
package org.apache.spark.deploy.rest.kubernetes
17+
package org.apache.spark.deploy.kubernetes.submit.v1
1918

2019
import io.fabric8.kubernetes.api.model.{Service, ServiceBuilder}
2120
import io.fabric8.kubernetes.client.KubernetesClient
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* See the License for the specific language governing permissions and
1515
* limitations under the License.
1616
*/
17-
package org.apache.spark.deploy.kubernetes
17+
package org.apache.spark.deploy.kubernetes.submit.v1
1818

1919
import java.io.{File, FileInputStream}
2020
import java.security.{KeyStore, SecureRandom}
@@ -29,7 +29,7 @@ import scala.collection.JavaConverters._
2929
import org.apache.spark.{SecurityManager => SparkSecurityManager, SparkConf, SparkException, SSLOptions}
3030
import org.apache.spark.deploy.kubernetes.config._
3131
import org.apache.spark.deploy.kubernetes.constants._
32-
import org.apache.spark.deploy.rest.kubernetes.{KubernetesFileUtils, PemsToKeyStoreConverter}
32+
import org.apache.spark.deploy.rest.kubernetes.v1.{KubernetesFileUtils, PemsToKeyStoreConverter}
3333
import org.apache.spark.util.Utils
3434

3535
/**

0 commit comments

Comments
 (0)