Skip to content

Added docker build arguments #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2018
Merged

Added docker build arguments #18

merged 1 commit into from
Jan 6, 2018

Conversation

@liyinan926
Copy link
Member

@liyinan926 liyinan926 commented Jan 5, 2018 •
edited
Loading

@liyinan926 liyinan926 force-pushed the docker-builder-fix branch 2 times, most recently from 33513b1 to 07f0867 Compare January 5, 2018 21:57
@liyinan926
Copy link
Member Author

liyinan926 commented Jan 5, 2018

I verified manually that build of spark-base worked with this fix.

@liyinan926
Copy link
Member Author

liyinan926 commented Jan 6, 2018

We need this to be merged to fix the scheduled runs.

@foxish
Copy link
Member

foxish commented Jan 6, 2018 via email

@liyinan926
Copy link
Member Author

liyinan926 commented Jan 6, 2018

Yes, manually ran the tests and all passed.

@liyinan926
Copy link
Member Author

liyinan926 commented Jan 6, 2018

I will merge once apache/spark#20170 gets merged.

@foxish foxish merged commit 98afa5a into apache-spark-on-k8s:master Jan 6, 2018
@foxish
Copy link
Member

foxish commented Jan 6, 2018

Sorry - I thought you wanted me to merge.
But should be ok either way - since tests are broken anyway for now - we'll see the effects only after that PR merges.

@liyinan926
Copy link
Member Author

liyinan926 commented Jan 6, 2018

No worries. The scheduled run should be back to normal after the upstream pr is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liyinan926 @foxish