Skip to content
This repository was archived by the owner on Sep 16, 2022. It is now read-only.

Commit f3cf5ea

Browse files
matanlureyferhatb
authored andcommitted
Move EVENT_MANAGERS_PLUGIN into a one-time list (no multi: true)
This is a _breaking_ change, but impact should be minimal since it's not widely advertised that this was even a feature. We can outline in the CHANGELOG if there are external users using this. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135297425
1 parent ee9e8d1 commit f3cf5ea

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

lib/src/platform/browser_common.dart

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import "package:angular2/core.dart"
1313
APPLICATION_COMMON_PROVIDERS,
1414
PLATFORM_COMMON_PROVIDERS,
1515
TestabilityRegistry;
16-
import "package:angular2/src/core/di.dart" show Provider, OpaqueToken;
16+
import "package:angular2/src/core/di.dart" show Injectable, Provider;
1717
import "package:angular2/src/core/profile/wtf_init.dart" show wtfInit;
1818
import "package:angular2/src/core/testability/testability.dart"
1919
show Testability;
@@ -27,7 +27,7 @@ import "package:angular2/src/platform/dom/dom_tokens.dart" show DOCUMENT;
2727
import "package:angular2/src/platform/dom/events/dom_events.dart"
2828
show DomEventsPlugin;
2929
import "package:angular2/src/platform/dom/events/event_manager.dart"
30-
show EventManager, EVENT_MANAGER_PLUGINS;
30+
show EventManager, EventManagerPlugin, EVENT_MANAGER_PLUGINS;
3131
import "package:angular2/src/platform/dom/events/hammer_gestures.dart"
3232
show HammerGesturesPlugin;
3333
import "package:angular2/src/platform/dom/events/hammer_gestures.dart"
@@ -82,10 +82,10 @@ const List<dynamic> BROWSER_APP_COMMON_PROVIDERS = const [
8282
const Provider(ExceptionHandler,
8383
useFactory: exceptionHandler, deps: const []),
8484
const Provider(DOCUMENT, useFactory: document, deps: const []),
85-
const Provider(EVENT_MANAGER_PLUGINS, useClass: DomEventsPlugin, multi: true),
86-
const Provider(EVENT_MANAGER_PLUGINS, useClass: KeyEventsPlugin, multi: true),
87-
const Provider(EVENT_MANAGER_PLUGINS,
88-
useClass: HammerGesturesPlugin, multi: true),
85+
DomEventsPlugin,
86+
KeyEventsPlugin,
87+
HammerGesturesPlugin,
88+
const Provider(EVENT_MANAGER_PLUGINS, useFactory: createEventPlugins),
8989
const Provider(HAMMER_GESTURE_CONFIG, useClass: HammerGestureConfig),
9090
DomRootRenderer,
9191
const Provider(RootRenderer, useExisting: DomRootRenderer),
@@ -97,6 +97,11 @@ const List<dynamic> CACHED_TEMPLATE_PROVIDER = const [
9797
const Provider(XHR, useClass: CachedXHR)
9898
];
9999

100+
@Injectable()
101+
List<EventManagerPlugin> createEventPlugins(DomEventsPlugin dom,
102+
KeyEventsPlugin keys, HammerGesturesPlugin hammer) =>
103+
new List<EventManagerPlugin>.unmodifiable([dom, keys, hammer]);
104+
100105
Function createInitDomAdapter(TestabilityRegistry testabilityRegistry) {
101106
return () {
102107
BrowserDomAdapter.makeCurrent();

0 commit comments

Comments
 (0)