spec: fix #1195, should create new taskData if using OPTIMIZED TASKDATA in event task (#1197)

Author: JiaLiPassion

lib/zone-spec/long-stack-trace.ts

@@ -109,6 +109,12 @@ function renderLongStackTrace(frames: LongStackTrace[], stack?: string): string
         trace.length = this.longStackTraceLimit;
       }
       if (!task.data) task.data = {};
+      if (task.type === 'eventTask') {
+        // Fix issue https://github.com/angular/zone.js/issues/1195,
+        // For event task of browser, by default, all task will share a
+        // singleton instance of data object, we should create a new one here
+        task.data = {...task.data};
+      }
       (task.data as any)[creationTrace] = trace;
     }
     return parentZoneDelegate.scheduleTask(targetZone, task);

test/zone-spec/long-stack-trace-zone.spec.ts

@@ -6,8 +6,8 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {isBrowser, zoneSymbol} from '../../lib/common/utils';
-import {ifEnvSupports, isSupportSetErrorStack} from '../test-util';
+import {isBrowser, isIE, zoneSymbol} from '../../lib/common/utils';
+import {ifEnvSupports, isSafari, isSupportSetErrorStack} from '../test-util';
 
 const defineProperty = (Object as any)[zoneSymbol('defineProperty')] || Object.defineProperty;
 
@@ -82,6 +82,40 @@ describe(
            });
          }));
 
+      it('should not overwrite long stack traces data for different optimized eventTasks',
+         ifEnvSupports(() => isBrowser, function() {
+           lstz.run(function() {
+             const button = document.createElement('button');
+             const clickEvent = document.createEvent('Event');
+             clickEvent.initEvent('click', true, true);
+             document.body.appendChild(button);
+
+             const div = document.createElement('div');
+             const enterEvent = document.createEvent('Event');
+             enterEvent.initEvent('mouseenter', true, true);
+             document.body.appendChild(div);
+
+             button.addEventListener('click', function() {
+               throw new Error('clickError');
+             });
+
+             div.addEventListener('mouseenter', function() {
+               throw new Error('enterError');
+             });
+
+             button.dispatchEvent(clickEvent);
+             div.dispatchEvent(enterEvent);
+
+             expect(log.length).toBe(2);
+             if (!isSafari() && !isIE()) {
+               expect(log[0].stack === log[1].stack).toBe(false);
+             }
+
+             document.body.removeChild(button);
+             document.body.removeChild(div);
+           });
+         }));
+
       it('should produce a long stack trace even if stack setter throws', (done) => {
         let wasStackAssigned = false;
         let error = new Error('Expected error');