This repository was archived by the owner on Feb 26, 2024. It is now read-only.
feat(helpers): add helpers module #212
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a helpers module as proposed in #211.
Goal
Centralize all helpers in a helpers module so they can be unit tested and reused in multiple places (e.g. in unit tests).
Helpers module
A helpers module has been added as
src/helpers.ats, exporting all helper functions so they can be individually imported:or as a whole:
Unit tests
Unit tests have been included to test the current behavior of the helpers.
Still left to do
@btford — I have not touched any of the existing router code so you will still have to import the helper functions in existing modules (e.g.
router.ats) and refactor existing code yourself.This is deliberate to:
If this PR needs additional work, please don't hesitate to let me know.
Thanks!