This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(colors): failing unit tests against Edge #9876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IE and Edge convert RGB colors to RGBA automatically, which was being handled by the `colors` unit tests via browser sniffing in IE. The browser sniffing doesn't work in Edge, which was causing the tests to fail. This hasn't been noticed until now since we've only been running the tests against IE 11. These changes switch to using feature detection to check whether the browser converts to RGBA.
ThomasBurleson
added
the
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IE and Edge convert RGB colors to RGBA automatically, which was being handled by the
colorsunit tests via browser sniffing in IE. The browser sniffing doesn't work in Edge, which was causing the tests to fail. This hasn't been noticed until now since we've only been running the tests against IE 11.These changes switch to using feature detection to check whether the browser converts to RGBA.