Skip to content

build: fix select test failure on smaller devices #9958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2018
Merged

build: fix select test failure on smaller devices #9958

merged 1 commit into from
Feb 15, 2018

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 14, 2018

Fixes one of the select positioning tests failing when running on a smaller device where the test component gets pushed too far down.

@crisbeto
build: fix select test failure on smaller devices
25e7736 
Fixes one of the select positioning tests failing when running on a smaller device where the test component gets pushed too far down.
@crisbeto crisbeto added the in progress This issue is currently in progress label Feb 14, 2018
@crisbeto crisbeto self-assigned this Feb 14, 2018
@crisbeto crisbeto requested a review from kara as a code owner February 14, 2018 20:30
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 14, 2018
@crisbeto crisbeto added pr: needs review and removed in progress This issue is currently in progress labels Feb 14, 2018
@crisbeto crisbeto assigned jelbourn and unassigned crisbeto Feb 14, 2018
jelbourn
jelbourn approved these changes Feb 14, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 14, 2018
@devversion devversion mentioned this pull request Feb 15, 2018
Closed
@jelbourn jelbourn merged commit 73bc948 into angular:master Feb 15, 2018
tinayuangao pushed a commit that referenced this pull request Feb 20, 2018
@crisbeto @tinayuangao
build: fix select test failure on smaller devices (#9958)
a119cd0 
Fixes one of the select positioning tests failing when running on a smaller device where the test component gets pushed too far down.
andrewseguin pushed a commit that referenced this pull request Feb 20, 2018
@crisbeto @andrewseguin
build: fix select test failure on smaller devices (#9958)
5e5b8b5 
Fixes one of the select positioning tests failing when running on a smaller device where the test component gets pushed too far down.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@kara kara Awaiting requested review from kara

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto @jelbourn @googlebot