Skip to content

Conversation

@devversion
Copy link
Member

@devversion devversion commented Feb 14, 2018

  • No longer runs tests on Saucelabs, because those jobs mostly time out, or are just flaky.
  • Allows reconnecting of browsers, if they accidentally disconnect on BrowserStack.

Should improve test stability in combination with #9949

@devversion devversion requested a review from jelbourn as a code owner February 14, 2018 12:18
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 14, 2018
@devversion devversion force-pushed the build/run-all-tests-browserstack branch from 3a0deb8 to 3a6578e Compare February 14, 2018 14:49
@devversion devversion added in progress This issue is currently in progress discussion and removed in progress in progress This issue is currently in progress labels Feb 14, 2018
@devversion devversion force-pushed the build/run-all-tests-browserstack branch from fd10dad to c09fbc6 Compare February 15, 2018 11:11
@devversion devversion changed the title [WIP] build: run all unit tests on browserstack build: run all unit tests on browserstack Feb 15, 2018
@devversion
Copy link
Member Author

Test failures should be fixed by #9958. Going to re-run once that one is in.

* No longer runs tests on Saucelabs, because those jobs mostly time out, or are just flaky.
@devversion devversion force-pushed the build/run-all-tests-browserstack branch from c09fbc6 to 59ae96e Compare February 17, 2018 11:15
@jelbourn
Copy link
Member

Seems like BrowserStack also has disconnect problems?

@devversion
Copy link
Member Author

It definitely has. But at least it runs more stable than Saucelabs. Also can be related to a flaky test, that is causing some serious performance issues.

@jelbourn
Copy link
Member

I don't know if I want to totally eliminate SauceLabs from our setup. It's really only the IE11 runs that have consistently been a problem.

@devversion
Copy link
Member Author

I don't agree with that IE flakiness though. Usually it's the whole setup that doesn't connect at all. Anyway, I kind of see that it's a bit too much removing it completely.

@devversion devversion closed this Feb 24, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants